Boost C++ Libraries: Ticket #6219: Apple macros break compile of has_binary_operator

Mon, 05 Dec 2011 21:48:56 GMT

(I regret not previewing the report, mea culpa for the cosmetic grinkles.)

cc set

Mon, 05 Dec 2011 21:49:46 GMT

cc j.gee@… added

Marshall Clow — Mon, 05 Dec 2011 22:19:11 GMT

This definition __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES=0 should definitely go into the darwin tool config.

component changed; owner set

Marshall Clow — Mon, 05 Dec 2011 22:25:57 GMT

owner set to Vladimir Prus
component None → Building Boost

Should probably also go into the clang-darwin toolset as well.

Changing to "building boost", and assigning to Vladmir. If he's not the right person, I'm sure he'll chime in.

component changed

René Rivera — Wed, 07 Dec 2011 02:53:11 GMT

component Building Boost → Regression Testing

Replying to marshall:

This definition __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES=0 should definitely go into the darwin tool config.

Perhaps.. But that doesn't actually solve the problem. For users that do not use BB it would still break. As would also anyone compiling with an older OSX,or iOS, SDK. So we need to identify where the problems in the code are an file individual bugs. And as a preliminary step we should add this macro to the inspection report, if it's not already there. And because of that I'm shifting this to the testing side.

component changed

viboes — Thu, 03 Jan 2013 18:54:55 GMT

component Regression Testing → type_traits

ben.craig@… — Mon, 06 Jan 2014 20:45:16 GMT

Just ran into this with boost 1.55. This could be fixed without ever touching ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES. Just change the static variable names in operator_exists ( type_traits/detail/has_binary_operator.hpp ) from "check" to something else.

Marshall Clow — Mon, 06 Jan 2014 21:55:05 GMT

Sadly, there is lots more than just this.

boost/container/detail/function_detector.hpp has a template member named "check"
Boost.Concept has structures named both "check" and "require"
Boost.Geometry has several uses of "check"

and the file <AssertMacros.h> defines many more macros than just those two.

ben.craig@… — Mon, 06 Jan 2014 22:05:19 GMT

The perfect is the enemy of the good?

Fixing has_binary_operator.hpp fixes a lot of real use cases (lexical_cast for one) by just changing some internal identifiers. Even if you don't fix every use case, you make some use cases better, without making any use cases worse.

anonymous — Wed, 15 Jan 2014 11:50:53 GMT

This took me almost two hours to sort out yesterday. Perhaps the addition of something like...

#if defined(__MACH__) && defined(__APPLE__) && defined(__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES) && __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES
#warning You will need to define ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES to 0 before the inclusion of Cocoa headers (perhaps in your prefix header)
#end if

...might help lower the impedance here. Or something to that effect. While it may be non-trivial to work around this vendor annoyance, mankind does possess the technology to at least shorten the path to the workaround.

status changed; resolution set

John Maddock — Sun, 20 Apr 2014 15:58:52 GMT

status new → closed
resolution → fixed

This is fixed in current develop (or at least type_traits is, can't comment on other libraries).