Boost C++ Libraries: Ticket #6277: Checked iterators are not threadsafe

attachment set

internet@… — Fri, 16 Dec 2011 10:33:24 GMT

attachment → cb.cpp

Code which demonstrates the bug

viboes — Tue, 21 May 2013 18:10:58 GMT

No library is thread-safe until it is stated explicitly. Where this is on the documentation?

anonymous — Wed, 22 May 2013 08:47:35 GMT

Replying to viboes:

No library is thread-safe until it is stated explicitly. Where this is on the documentation?

Here: http://www.boost.org/doc/libs/1_53_0/libs/circular_buffer/doc/circular_buffer.html#threadsafety

"simultaneous read accesses to a shared circular_buffer are safe."

This is also a requirement for C++11.

owner, status changed

viboes — Sun, 09 Jun 2013 21:11:42 GMT

owner changed from Jan Gaspar to viboes
status new → assigned

Oh thanks for clarification. What do you think of removing this specific debug behavior?

// BOOST_CB_ENABLE_DEBUG: Debug support control.
#if defined(NDEBUG) || defined(BOOST_CB_DISABLE_DEBUG)
    #define BOOST_CB_ENABLE_DEBUG 0
#else
    #define BOOST_CB_ENABLE_DEBUG 1
#endif

// Debug enable is disabled temporarily as the associated code is not thread safe?
#undef BOOST_CB_ENABLE_DEBUG

severity changed

viboes — Sun, 09 Jun 2013 21:15:45 GMT

severity Showstopper → Problem

As there is a workaround this is not a Showstopper.

ronan.keryell@… — Fri, 29 Jan 2016 23:52:59 GMT

Replying to viboes:

As there is a workaround this is not a Showstopper.

Recently I spent more than a week chasing some bugs that ended up to be in this racy debug code of Boost Circular Buffer...

So at least if it is not considered as a show-stopper, the issue and the work-around should be explained in the documentation in sections "Thread-Safety" and "Debug Support" of http://www.boost.org/doc/libs/1_60_0/doc/html/circular_buffer/implementation.html

Besides this, this library is great! Thanks.

Andrey Semashev — Thu, 28 Apr 2016 22:01:03 GMT

I've created a PR to fix this: https://github.com/boostorg/circular_buffer/pull/9.

ronan.keryell@… — Mon, 02 May 2016 08:24:58 GMT

Replying to andysem:

I've created a PR to fix this: https://github.com/boostorg/circular_buffer/pull/9.

Nice! I've tried your version in https://github.com/amd/triSYCL/commit/dd5adeb9d8954ebccf13b837e5a6d415752db490 and it works. So, for me, it looks ready to land.

Thank you for your fix of this 4 year old bug!

status changed; resolution set

Andrey Semashev — Fri, 12 Aug 2016 04:57:56 GMT

status assigned → closed
resolution → fixed