Boost C++ Libraries: Ticket #6349: use of missing ::abort

keywords set

ulrich.eckhardt@… — Wed, 11 Jan 2012 16:10:37 GMT

keywords wince added

Same problem here, using Boost 1.48. The target platform is MS Windows CE 6 with STLport 5.2 and MSVC 8.0 (VS 2005). There is a workaround in a different place already that simply checks

  #if defined(UNDER_CE)
    // some CE platforms don't define ::abort(), let alone std::abort()
    exit(-1);
  #else
    abort();
  #endif

I have found other places that use abort() to e.g. mark code as unreachable. They could use similar workarounds. I'm just in the process of migrating to 1.48 but I should be able to produce a patch for this.

type changed; cc set

viboes — Mon, 26 Mar 2012 21:14:31 GMT

cc viboes added
type Support Requests → Bugs

Any new on this?

Tue, 27 Mar 2012 17:28:00 GMT

Sorry, I've been distracted by different things, but it's still on my TODO list...

Emil Dotchevski — Tue, 27 Mar 2012 19:35:39 GMT

Please check if trunk revision 77593 fixes the problem.

Tue, 03 Apr 2012 07:54:15 GMT

No, r77593 doesn't help. Neither CE5 nor CE6 have an abort() function anywhere.

BTW: If you commit with "(refs #6349)" in the commit message, TRAC automatically makes a note in the according bug ticket, so you don't have to add one yourself. All subscribers of the ticket also get an automatic notification.

serggzz@… — Fri, 13 Apr 2012 12:50:22 GMT

As I see this bug steel exists, https://svn.boost.org/trac/boost/search?q=std%3A%3Aabort&noquickjump=1&ticket=on

Does anybody know why assert.hpp is so often included after config.hpp? I'm intended to use BOOST_USER_CONFIG to figure this problem out but now it's impossible. Examples are:

<boost/ptr_container/ptr_vector.hpp> => <boost/ptr_container/ptr_sequence_adapter.hpp> => <boost/ptr_container/detail/reversible_ptr_container.hpp> => <boost/ptr_container/detail/throw_exception.hpp> => #include <boost/assert.hpp> #include <boost/config.hpp>
<boost/scoped_ptr.hpp> => <boost/smart_ptr/scoped_ptr.hpp> => the first include is #include <boost/assert.hpp> I think that <boost/config.hpp> must be the first include every time.

It's only my curiosity why there are no any guards in assert.hpp and it's intended?

Emil Dotchevski — Fri, 13 Apr 2012 18:34:52 GMT

assert.hpp probably follows the design of assert.h, which lacks include guards so that it can be included multiple times within the same source file, with different combination of _DEBUG/NDEBUG defined.

attachment set

David Deakins — Mon, 23 Apr 2012 04:33:00 GMT

attachment → boost-exception-exception_ptr.hpp.3.patch

David Deakins — Mon, 23 Apr 2012 04:33:40 GMT

Hi Emil,

Since this issue with abort is disrupting a lot of test result reporting for Windows CE, do you mind if I apply the attached patch for this issue or would you like to do it yourself?

Thanks, -Dave

David Deakins — Wed, 25 Apr 2012 03:57:15 GMT

Committed the patch. Will let the tests cycle and confirm that the issue is resolved.

status changed; resolution set

David Deakins — Fri, 27 Apr 2012 15:24:10 GMT

status new → closed
resolution → fixed