integer overflow in boost::chrono::process_real_cpu_clock::now() under Windows 32bits

[ivan.lelann@…]

As of 1.48 Boost.Chrono contains code below for boost::chrono::process_real_cpu_clock::now() (boost\chrono\detail\inlined\win\process_cpu_clocks.hpp)

clock_t c = ::clock(); /* ... */ return time_point(

duration(c*(1000000000l/CLOCKS_PER_SEC))

);

duration::rep is int64/nanoseconds, clock_t is long. This is under VS2008, Win XP 32bits. I think "c" should be cast to duration::rep before being multiplied.

C-style cast fixed the problem for me. Howard Hinnant suggested following cleaner fix on the mailing list :

typedef ratio_divide<giga, ratio<CLOCKS_PER_SEC>>::type R; return time_point(

duration(static_cast<rep>(c)*R::num/R::den)

);

NB: This appears at least twice in this file. It also appears in "mac" and "posix" folders though I cannot say if it is problematic on this platforms.

[viboes]

Sorry, I forget this issue. I will take care of it as soon as I have access to a windows machine.

[viboes]

Committed in trunk At revision: [77545]

[viboes]

(In [77694]) Chrono Fix #6361,#6628,#6666