Boost C++ Libraries: Ticket #6406: Use attribute names with underscores for GCC

attachment set

Mon, 16 Jan 2012 22:54:18 GMT

attachment → boost-xpressive.patch

component changed; owner set

Mon, 16 Jan 2012 22:56:20 GMT

owner set to Eric Niebler
component None → xpressive

Eric Niebler — Mon, 16 Jan 2012 23:17:51 GMT

Can you point to official gcc documentation that show that this is a supported and equivalent syntax? All I see is here: http://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html, which seems to indicate that the original code is the correct form. And if the form you suggested is allowed, then is it only a recent addition?

status changed; resolution set

Eric Niebler — Tue, 17 Jan 2012 16:06:45 GMT

status new → closed
resolution → invalid

Resolving as invalid for now. If you can show that this has been supported syntax for a long time, feel free to reopen.

Fri, 20 Jan 2012 16:26:33 GMT

I updated the ticket #6416 with some evidence that this is a long-supported feature.

status changed; resolution deleted

Fri, 27 Jan 2012 15:38:08 GMT

status closed → reopened
resolution invalid

Fri, 27 Jan 2012 15:40:02 GMT

The double underscore feature is described here: http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html and it has worked "forever" (I tried GCC 3.3, but reportedly it's been supported all the way back to GCC 2.95.7).

status changed; resolution set

Eric Niebler — Sat, 28 Jan 2012 20:08:37 GMT

status reopened → closed
resolution → fixed

(In [76766]) use underscores in gcc attribute names, fixes #6406

status, version, milestone changed; resolution deleted

Denis Arnaud — Thu, 19 Jul 2012 20:25:23 GMT

status closed → reopened
version Boost 1.48.0 → Boost 1.50.0
resolution fixed
milestone To Be Determined → Boost 1.51.0

The bug has been fixed on trunk (http://svn.boost.org/svn/boost/trunk/boost/xpressive/detail/core/adaptor.hpp), but not on the release branch (http://svn.boost.org/svn/boost/branches/release/boost/xpressive/detail/core/adaptor.hpp)...

Could you integrate the fix in the release branch as well?

status changed; resolution set

Eric Niebler — Fri, 20 Jul 2012 05:57:09 GMT

status reopened → closed
resolution → fixed

Oops. Merged to release in [79614]. Thanks for spotting that.