Boost C++ Libraries: Ticket #6416: Use attribute names with underscores for GCC

attachment set

Mon, 16 Jan 2012 23:08:25 GMT

attachment → boost-accumulators.patch

Eric Niebler — Mon, 16 Jan 2012 23:18:10 GMT

Can you point to official gcc documentation that show that this is a supported and equivalent syntax? All I see is here: http://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html, which seems to indicate that the original code is the correct form. And if the form you suggested is allowed, then is it only a recent addition?

status changed; resolution set

Eric Niebler — Tue, 17 Jan 2012 16:06:08 GMT

status new → closed
resolution → invalid

Resolving as invalid for now. If you can show that this has been supported syntax for a long time, feel free to reopen.

Fri, 20 Jan 2012 16:23:40 GMT

Curiously, no, I can't, it doesn't seem to be documented, but it's been supported since "forever". It's used internally by stdlibc++, and boost even uses this syntax in a couple places (move, type traits). With GCC 3.3, which is the oldest that I have around, I'm getting this:

  __attribute__ ((__noinline__)) int ble() { return 10; } // passes quietly
  __attribute__ ((__sdkfljlk__)) int ble2() { return 10; } // gives warning

(Hopefully I typed this correctly, the machine that I tested this on is not networked.)

The code in boost is not incorrect, it just lends itself easier to user-defined macros. The underscore syntax is supported by GCC to remedy this. Please consider applying the patch.

resolution changed

Eric Niebler — Sun, 22 Jan 2012 17:56:12 GMT

resolution invalid → fixed

(In [76637]) Use attribute names with underscores for GCC, fixes #6416