Boost C++ Libraries: Ticket #650: Invalid code used for add w/ overflow checking

jmaurer — Thu, 29 Jun 2006 23:19:09 GMT

Logged In: YES
user_id=53943
Thanks for the report, sorry for the delay.
I've checked in this patch which should fix the issue.
--- const_mod.hpp       27 Jul 2004 03:43:32 -0000      1.8
+++ const_mod.hpp       29 Jun 2006 23:15:39 -0000
@@ -43,10 +43,10 @@
     template<class IntType>
     static IntType add(IntType m, IntType x, IntType c)
     {
-      x += (c-m);
-      if(x < 0)
-        x += m;
-      return x;
+      if (x < m - c)
+        return x + c;
+      else
+        return x - (m-c);
     }
   };

status changed

jmaurer — Thu, 29 Jun 2006 23:19:10 GMT

status assigned → closed

severity set

Cialis buy online — Mon, 08 Jun 2009 11:20:17 GMT

severity → Showstopper

Is it NOUVELLE CUISINE when 3 olives are struggling with a scallop in a plate of SAUCE MORNAY? comprare viagra dall'Italia fioricet uses buy Cialis medication Tq1iKUm cheap tramadol

cialis rx — Sat, 08 Aug 2009 13:46:16 GMT

Apples have meant trouble since eden.

-- MaDsen Wikholm, mwikholm@…

viagra ordina adesso in italia buy fioricet pills cialis buy viagra ordina propecia TQVo/7c