pool.free() crashes if given a null pointer

[Étienne Dupuis <e.dupuis@…>]

The documentation states that the pointer given to pool.free() should be a pointer returned by pool.malloc().

However, if pool.malloc() fails and return a null value, calling pool.free() with the returned value does crash...

It would be nice if pool.free() did not crash given a null pointer.

Example crash :

pool.free(pool.malloc());

Regards

[edupuis]

(In [78317]) Pool no longer crashes when freeing a null pointer. This is somewhat like the free() function and the delete operator and fixes #6561.

[edupuis]

​https://svn.boost.org/svn/boost/sandbox/pool at revision 79460 contains a solution for tickets #3789, #5902, #6561, #6610, #6701, #6718, #6865 and #6867. Related test cases are also present.

​https://svn.boost.org/svn/boost/sandbox/pool at revision 79460 does not contain any other new features or modifications other than those related to the above tickets.

Boost.Pool currently has no maintainer and is thus orphaned.

[James E. King, III]

I can confirm this is still an issue in 1.67.0:

boost@ee79ac718c30:/boost/libs/pool/test$ cat test_bug_6561.cpp
/* Copyright (C) 2018 James E. King III
*
* Use, modification and distribution is subject to the
* Boost Software License, Version 1.0. (See accompanying
* file LICENSE_1_0.txt or http://www.boost.org/LICENSE_1_0.txt)
*/

// Test of bug #6561 (https://svn.boost.org/trac/boost/ticket/6561)

#include <boost/assert.hpp>
#include <boost/pool/simple_segregated_storage.hpp>
#include <boost/smart_ptr/scoped_ptr.hpp>

int main()
{
    boost::simple_segregated_storage<std::size_t> storage;
    storage.free(0);
    return 0;
}

That will produce a segfault.