Boost C++ Libraries: Ticket #6578: Update noncopyable for C++11

attachment set

Daryle Walker — Sat, 18 Feb 2012 20:16:13 GMT

attachment → noncopyable_cpp11.git.2.diff

Changes for updating noncopyable for Cxx11

owner, status changed

viboes — Mon, 04 Feb 2013 22:34:21 GMT

owner changed from No-Maintainer to viboes
status new → assigned

milestone changed

viboes — Wed, 10 Apr 2013 17:16:36 GMT

milestone Boost 1.50.0 → Boost 1.54.0

Committed revision [83833].

status changed; resolution set

viboes — Sat, 13 Apr 2013 13:49:54 GMT

status assigned → closed
resolution → fixed

(In [83869]) utility/noncopyable : fix #6578.

status changed; resolution deleted

Robert Ramey — Sun, 10 Nov 2013 21:31:03 GMT

status closed → reopened
resolution fixed

Vicente,

I'm having a problem with this patch. My gcc 4.53 compiler gives the error message:

"noncopayable:: declared with non-public access cannot be defaulted in the class body"

Which seems to make some sense to me. My copy of the standard (section 8.4.2) says "If it[the function] is explicitly defaulted on its first declaration, — it shall be public," As usual the standard text is somewhat convoluted, but that what it says to me. I'm not sure why the test passes. The macro name (BOOST_NO_DEFAULTED_FUNCTIONS used to condition this code has been marked as deprecated in favor of a new one (BOOST_NO_CXX11_DEFAULTED_FUNCTIONS) i don't know if that might be related.

Robert Ramey

viboes — Mon, 11 Nov 2013 11:28:05 GMT

I have no access to gcc-4.5.3. Please could you move to the public section and see how it works?

status, milestone changed; resolution set

viboes — Sat, 04 Apr 2015 21:22:30 GMT

status reopened → closed
resolution → fixed
milestone Boost 1.54.0 → Boost 1.58.0

It seems the new code fixes this issue.

  class noncopyable
  {
  protected:
#if !defined(BOOST_NO_CXX11_DEFAULTED_FUNCTIONS) && !defined(BOOST_NO_CXX11_NON_PUBLIC_DEFAULTED_FUNCTIONS)
      BOOST_CONSTEXPR noncopyable() = default;
      ~noncopyable() = default;
#else
      noncopyable() {}
      ~noncopyable() {}
#endif
#if !defined(BOOST_NO_CXX11_DELETED_FUNCTIONS)
      noncopyable( const noncopyable& ) = delete;
      noncopyable& operator=( const noncopyable& ) = delete;
#else
  private:  // emphasize the following members are private
      noncopyable( const noncopyable& );
      noncopyable& operator=( const noncopyable& );
#endif
  };