Boost C++ Libraries: Ticket #6635: Boost.Locale UTF encode function passes wrong type to output iterator

attachment set

jason.erb@… — Wed, 29 Feb 2012 05:38:10 GMT

attachment → 6635.patch

Patch for #6635

status, severity, milestone changed

Artyom Beilis — Wed, 29 Feb 2012 07:41:03 GMT

status new → assigned
severity Problem → Cosmetic
milestone To Be Determined → Boost 1.50.0

AFAIK there should be no warning for conversion between integral and character type. It is done all over the code in all places.

Casting to char_type would eliminate the warning but I'm not sure it is the correct approach.

I'll think about it.

Wed, 29 Feb 2012 14:44:27 GMT

Thanks for looking into this. Here is the specific message:

error: implicit conversion loses integer precision: 'code_point' (aka 'unsigned int') to 'const char' [-Werror,-Wconversion]

I have used various boost libraries for a long time with these warnings enabled and this is the first library in which I have hit this problem. In my view, the cast is entirely appropriate in this case: the user has specified CharType as the code unit type, so the code units sent to the output iterator should be of this type.

Artyom Beilis — Wed, 02 May 2012 13:29:34 GMT

Fixed in changeset #78304 in trunk

status changed; resolution set

Artyom Beilis — Wed, 02 May 2012 13:49:51 GMT

status assigned → closed
resolution → fixed