Boost C++ Libraries: Ticket #6693: tribool.hpp causes warnings under -Wshadow on gcc

attachment set

Fri, 16 Mar 2012 18:32:39 GMT

attachment → shadow.patch

Patch to tribool shadowing issue

component changed; owner set

Fri, 16 Mar 2012 18:39:04 GMT

owner set to Douglas Gregor
component None → logic

owner, status changed

Marshall Clow — Fri, 16 Mar 2012 20:11:01 GMT

owner changed from Douglas Gregor to Marshall Clow
status new → assigned

Here's what I see in that file (both on trunk and release):

   * \throws nothrow
   */
  tribool(bool initial_value) : value(initial_value? true_value : false_value) {}

It appears to me that this was fixed back in 2009.

------------------------------------------------------------------------
r53429 | vladimir_prus | 2009-05-29 23:36:18 -0700 (Fri, 29 May 2009) | 4 lines
Fix gcc -Wshadow warnings in tribool.

Are you sure that you are using version 1.49?

Fri, 16 Mar 2012 20:18:15 GMT

Arg! sorry about that. We use 1.46.1 internally, where we locally patched this problem, and two similar ones in the random library. When setting this patch up, I saw that everything in random had been cleared up, but I managed to forget / mess up this comparison.

This can be closed / rejected.

status changed; resolution set

Marshall Clow — Fri, 16 Mar 2012 20:48:59 GMT

status assigned → closed
resolution → invalid