Boost C++ Libraries: Ticket #6714: utree::insert return begin() if position == end()

Joel de Guzman — Tue, 20 Mar 2012 13:45:29 GMT

That's incorrect. Insert only returns begin() IF position == end() AND the container is empty. There is nothing wrong with the logic as it is. If you don't agree, feel free to attach a test case that proves that the logic is wrong. Please do so ASAP. I do not want to have lingering open issues. Thanks.

anonymous — Tue, 20 Mar 2012 14:04:42 GMT

That does not seem to be the case. The following fails for me:

#include "boost/spirit/home/support/utree.hpp"
#include <cassert>
int main()
{
	boost::spirit::utree ut;
	ut.push_back(1);
	assert( ut.insert( ut.end(), 1 ) != ut.begin() );
}

If one takes a look at boost::utree::end() it creates an iterator with 0 as node ( makes sense I presume ). The guard is then:

if (!pos.node)
{
        l.push_back(val);
        return utree::iterator(l.first, 0); // begin();
}

As pos.node == 0 for all end() it would seem it doesn't matter how many items are in the utree. Perhaps I'm missing something?

status changed; resolution set

Joel de Guzman — Tue, 20 Mar 2012 15:16:06 GMT

status new → closed
resolution → fixed

No, you are right and I am blind! Fixed in trunk. Please verify; tests added.