Boost C++ Libraries: Ticket #6766: incorrect declaration for putenv in config.hpp

owner changed

Gennadiy Rozental — Mon, 05 Nov 2012 09:55:28 GMT

owner changed from Gennadiy Rozental to Steven Watanabe

Steven,

This was your addition. I do not have access to this platform anymore. Do you mind looking into this?

Thu, 05 Mar 2015 18:29:40 GMT

I see this failure in my Nightly regression testing in the develop branch when compiling libs/test/src/unit_test_parameters.cpp

"/usr/include/stdlib.h", line 113: Error: putenv(char*) was declared before with a different language. 1 Error(s) detected.

This seems to prevent building of libboost_unit_test_framework.a

...skipped <p/export/users/akumta/BOOST_REGRESSION_patch_local/results/boost/bin.v2/libs/test/build/sun-stlport4/release/link-static/threading-multi>libboost_unit_test_framework.a for lack of <p/export/users/akumta/BOOST_REGRESSION_patch_local/results/boost/bin.v2/libs/test/build/sun-stlport4/release/link-static/threading-multi>unit_test_parameters.o...

Any idea when this fix could go in?

Thank you.

Thu, 05 Mar 2015 18:31:41 GMT

I see this failure in my Nightly regression testing in the develop branch when compiling libs/test/src/unit_test_parameters.cpp

"/usr/include/stdlib.h", line 113: Error: putenv(char*) was declared before with a different language. 1 Error(s) detected.

This seems to prevent building of libboost_unit_test_framework.a

Any idea when this fix could go in?

Thank you.

Raffi Enficiaud — Wed, 11 Mar 2015 21:52:37 GMT

The best would be to know which version of the SUNPRO_CC compiler the

extern "C" void putenv

is needed and change this as a workaround for version of the compiler earlier than this one.

The problem is: no one has a Sun here.

Digging a bit more: I can see a similar commit in rev cd47d62b4677b003a75885db5d08d50a1a586bf6 for the execution_monitor.hpp. So why not just having that in the config file?

What version of the compiler do you have right now?

Steven Watanabe — Wed, 11 Mar 2015 22:07:06 GMT

I suspect that #include <stdlib.h> was the correct fix even when I put the workaround in originally. If I remember correctly I was running Solaris 10, Sun CC 5.9.

Raffi Enficiaud — Wed, 11 Mar 2015 22:13:40 GMT

Thanks. I am in favor of removing the hack and including the stdlib.

owner, status changed

Raffi Enficiaud — Sat, 21 Mar 2015 15:55:39 GMT

owner changed from Steven Watanabe to Raffi Enficiaud
status new → assigned

Tentative fix branch tractickets/6766-incorrect-declaration-for-putenv-in-config.hpp, commit 17bef37 (see PR #36)

Waiting for feedback before merging.

Thu, 26 Mar 2015 17:34:43 GMT

Branch tractickets/6766-incorrect-declaration-for-putenv-in- config.hpp, commit 17bef37 has been tested with Oracle Solaris Studio compiler and the fix looks good.

This ticket prevents building of libboost_unit_test_framework.a. As a result many tests (from accumulators, algorithm, assign, lexical_cast, msm, odeint, polygon, range and sync) fail due to a dependency on libboost_unit_test_framework.a. The fix significantly improves the pass rate of the test runs by 15% .

We would highly appreciate it if the fix can be putback to develop/master so it can make 1.58 release.

Raffi Enficiaud — Sat, 28 Mar 2015 00:55:06 GMT

Will be in develop soon, thanks for your patience.

status, milestone changed; resolution set

Raffi Enficiaud — Tue, 07 Jul 2015 07:44:35 GMT

status assigned → closed
resolution → fixed
milestone To Be Determined → Boost 1.59.0