Boost C++ Libraries: Ticket #6843: [Intel C++] Compile Errors with '#include '

attachment set

Sat, 28 Apr 2012 16:58:43 GMT

attachment → boost-future-intel-fix-20120421-0519.patch

Fist patch. Massive hack. Needs improvement.

owner, component changed

viboes — Mon, 28 May 2012 16:05:57 GMT

owner changed from Anthony Williams to Peter Dimov
component thread → smart_ptr

Hi,

I guess this problem is related to Boost.SmartPtr as the functions atomic_xxx are defined in smart_ptr/shared_ptr.hpp.

Sat, 02 Jun 2012 05:29:35 GMT

Right, but doesn't it need to be worked around at the call site (like I've done in my patch)? How would you propose to fix it in shared_ptr at the point where it's declared/defined? I'd love to hear if you have a better way to fix it.

Thanks for taking the time to read and respond to the ticket.

owner, status, component changed

viboes — Thu, 04 Apr 2013 03:46:54 GMT

owner changed from Peter Dimov to viboes
status new → assigned
component smart_ptr → thread

An alternative could be to use a file that does the undef of all the concerned macros and another that does the redef.

#include <boost/detail/atomic/undef_macros.hpp>
if(!atomic_load(&future_))
{
  future_ptr blank;
  atomic_compare_exchange(&future_,&blank,future_ptr(new detail::future_object<R>));
}
#include <boost/detail/atomic/redef_macros.hpp>

This has the advantage to have less noise. The same kind of patch can be applied to #6842

Thu, 04 Apr 2013 07:07:01 GMT

Yep, that would work great. Like I said originally, my first patch was a massive hack because I just wanted to get my development unblocked.

Your solution looks much nicer, and I look forward to not having to patch my copy locally in the future. :)

Thanks for looking into it again.

viboes — Sun, 07 Apr 2013 22:23:28 GMT

Replying to Joshua Boyce <raptorfactor@…>:

Yep, that would work great. Like I said originally, my first patch was a massive hack because I just wanted to get my development unblocked.

Your solution looks much nicer, and I look forward to not having to patch my copy locally in the future. :)

Thanks for looking into it again.

It will be too late for 1.54. I will try it very soon.

milestone changed

viboes — Sun, 14 Apr 2013 21:25:01 GMT

milestone To Be Determined → Boost 1.54.0

Committed revision [83903] including new files. Committed revision 83904 specific thread patch.

status changed; resolution set

viboes — Wed, 17 Apr 2013 04:30:51 GMT

status assigned → closed
resolution → fixed

(In [83938]) Thread: merge from trunk to fix #6843,#6966.