Boost C++ Libraries: Ticket #6886: Bugs in boost/regex/icu.hpp (patch included)

Thu, 10 May 2012 11:36:21 GMT

Whoops, formatting... the patch:

314c314
<    typedef std::vector<UCHAR32> vector_type;
---
>    typedef std::vector<UChar32> vector_type;
318,319c318,319
<       v.push_back((UCHAR32)(*i));
<       ++a;
---
>       v.push_back((UChar32)(*i));
>       ++i;

We (my employer) have been using this patch for the last three or four years, so you could say it's tested. ;-)

summary changed

Fri, 11 May 2012 07:44:11 GMT

summary Bugs in boost/regex/icu.hpp → Bugs in boost/regex/icu.hpp (patch included)

John Maddock — Fri, 11 May 2012 18:15:39 GMT

I believe all these issues have been fixed, note that the source code you referenced was in the old CVS repro which hasn't been used in many years. Current source is here: http://svn.boost.org/svn/boost/trunk/boost/regex/icu.hpp and doesn't contain UCHAR32 anywhere.

Please reopen if I've missed anything.

BTW, can the IBM specific workarounds be removed from recent compiler releases?

anonymous — Fri, 11 May 2012 20:17:55 GMT

Ah, I see... perhaps it would be a good idea to link the source somewhere (more) prominent from boost.org, and shutting down the SF.net repo in the admin interface. (It was possible to do so when I last used SourceForge, which admittedly is a couple of years since.) I clicked around the site for some time looking for "my" patch, and eventually ended up in the SF.net repository thinking that the issue hadn't been fixed.

I'll give the new IBM compiler a try sometime next week.

status changed; resolution set

John Maddock — Tue, 15 May 2012 16:08:59 GMT

status new → closed
resolution → worksforme