Boost C++ Libraries: Ticket #6888: range::unique does not forward predicate https://svn.boost.org/trac10/ticket/6888 <p> At boost\range\algorithm\unique.hpp:92 </p> <pre class="wiki">/// \overload template&lt; class ForwardRange, class BinaryPredicate &gt; inline BOOST_DEDUCED_TYPENAME range_return&lt;ForwardRange, return_begin_found&gt;::type unique( ForwardRange&amp; rng, BinaryPredicate pred ) { BOOST_RANGE_CONCEPT_ASSERT(( ForwardRangeConcept&lt;ForwardRange&gt; )); return ::boost::range::unique&lt;return_begin_found&gt;(rng); } </pre><p> does not forward pred </p> en-us Boost C++ Libraries /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/6888 Trac 1.4.3 andy@… Thu, 10 May 2012 14:08:07 GMT attachment set https://svn.boost.org/trac10/ticket/6888 https://svn.boost.org/trac10/ticket/6888 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">unique_bug.cpp</span> </li> </ul> <p> Example of bug </p> Ticket andy@… Thu, 10 May 2012 14:25:02 GMT attachment set https://svn.boost.org/trac10/ticket/6888 https://svn.boost.org/trac10/ticket/6888 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">unique_fix.diff</span> </li> </ul> <p> Bug fix + test expansion to cover </p> Ticket andy@… Thu, 10 May 2012 14:29:34 GMT <link>https://svn.boost.org/trac10/ticket/6888#comment:1 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/6888#comment:1</guid> <description> <p> I also changed the signature of the function accepting a const range&amp;, range/algorithm/unique.hpp:96 </p> <pre class="wiki">inline BOOST_DEDUCED_TYPENAME range_return&lt;const ForwardRange, return_begin_found&gt;::type </pre><p> That is in line with the other overloads, and I couldn't get the newer tests to work without that. </p> <p> Additionally, in the unique.cpp tests, the predicate being used was incorrect - it was using std::less and std::greater for comparing equality. I changed them to be using std::equal_to </p> </description> <category>Ticket</category> </item> <item> <author>andy@…</author> <pubDate>Thu, 10 May 2012 14:44:41 GMT</pubDate> <title>component changed; owner set https://svn.boost.org/trac10/ticket/6888#comment:2 https://svn.boost.org/trac10/ticket/6888#comment:2 <ul> <li><strong>owner</strong> set to <span class="trac-author">Neil Groves</span> </li> <li><strong>component</strong> <span class="trac-field-old">None</span> → <span class="trac-field-new">range</span> </li> </ul> Ticket Neil Groves Sun, 15 Sep 2013 19:46:00 GMT <link>https://svn.boost.org/trac10/ticket/6888#comment:3 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/6888#comment:3</guid> <description> <p> The proposed changes have been applied to the trunk. Thanks for helping. Please accept my apologies for failing to cover the full overload set. </p> </description> <category>Ticket</category> </item> <item> <author>andy@…</author> <pubDate>Mon, 16 Sep 2013 02:00:01 GMT</pubDate> <title/> <link>https://svn.boost.org/trac10/ticket/6888#comment:4 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/6888#comment:4</guid> <description> <p> No apology necessary! I love the Boost Range library, and am happy to have helped in this small way. </p> </description> <category>Ticket</category> </item> <item> <dc:creator>Neil Groves</dc:creator> <pubDate>Mon, 24 Feb 2014 15:22:02 GMT</pubDate> <title>status changed; resolution set https://svn.boost.org/trac10/ticket/6888#comment:5 https://svn.boost.org/trac10/ticket/6888#comment:5 <ul> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> Ticket