Boost C++ Libraries: Ticket #7025: circular buffer reports warning: " type qualifiers ignored on function return type" while compile.

description changed

viboes — Tue, 21 May 2013 18:12:00 GMT

description modified (diff)

owner, status changed

viboes — Tue, 21 May 2013 18:12:48 GMT

owner changed from Jan Gaspar to viboes
status new → assigned

component changed

viboes — Sun, 09 Jun 2013 20:42:53 GMT

component circular_buffer → call_traits

I suspect that this need a change in boost/detail/call_traits.hpp

The following

template <typename T>
struct ct_imp2<T, true>
{
   typedef const T param_type;
};

should be

template <typename T>
struct ct_imp2<T, true>
{
   typedef T param_type;
};

owner, status changed

viboes — Sun, 09 Jun 2013 20:44:07 GMT

owner changed from viboes to John Maddock
status assigned → new

owner changed

John Maddock — Thu, 13 Jun 2013 15:39:50 GMT

owner changed from John Maddock to viboes

I'm unable to reproduce here - anyone have a test case?

In any case, circular_buffer is abusing call_traits::param_type which is designed for parameters and not return values. And yes it really should be const ;-)

Use call_traits::value_type or call_traits::const_reference for those return types (I think I would settle for the latter).

component changed

viboes — Sun, 07 Jul 2013 10:33:49 GMT

component call_traits → circular_buffer

You are right. As the documentation states, the return type should be const_reference.

milestone changed

viboes — Sun, 07 Jul 2013 13:01:34 GMT

milestone To Be Determined → Boost 1.55.0

Committed revision [84971].

status changed; resolution set

viboes — Tue, 10 Sep 2013 22:14:35 GMT

status new → closed
resolution → fixed