Boost C++ Libraries: Ticket #7070: bcp misses some cases and does not create namespace aliases for non-boost namespaces

attachment set

Wed, 04 Jul 2012 00:01:09 GMT

attachment → copy_path.cpp.patch

lukester_null@… — Thu, 05 Jul 2012 10:30:26 GMT

I hope I'm not thread jacking but I'd just like to say this is great - fixes something I was just about to create a ticket for. It was converting:

namespace boost{ namespace phoenix

namespace MyBoost { namespace MyBoostphoenix

But missing things like:

BOOST_PHOENIX_DEFINE_EXPRESSION(
    (boost)(phoenix)(do_while)

which ended up as

    (MyBoost)(phoenix)(do_while)

which your patch makes (MyBoost)(MyBoostphoenix)(do_while)

I'm not sure I understand why it prefixes the new top-level namespace on the phoenix namespace at all, though I guess it's intentional?

Regards

Luke.

Thu, 05 Jul 2012 18:57:51 GMT

I wondered that too until I found the header files under boost/spirit/home/classic/phoenix .

lukester_null@… — Thu, 05 Jul 2012 19:39:02 GMT

Ah right, so the classic phoenix namespace gets renamed because it's not nested inside the boost namespace to avoid any potential clashes, and the new phoenix(es) namespace which are nested in boost get caught in the crossfire... or something.

If so, I wonder if that was the desired effect? Most of the new boost::phoenix namespace declarations I've seen are all on one line so it's presumably possible to catch them.

Fri, 06 Jul 2012 01:43:04 GMT

I can see why each namespace declaration is renamed independently of any others, since extra code can show up before the embedded phoenix namespace declaration, and so you don't want to write more complicated patterns in an attempt to catch this situation. This then leads to the forced rename of the embedded phoenix namespace during namespace resolution.

In any case, the patch to catch the other renamed namespaces should make this annoyance go away.

John Maddock — Tue, 10 Jul 2012 11:07:33 GMT

Thanks for the patch, currently testing it out.

status changed; resolution set

John Maddock — Tue, 10 Jul 2012 17:41:14 GMT

status new → closed
resolution → fixed

(In [79403]) Apply patch from #7070 to fix namespace renaming. Fixes #7070.