Boost C++ Libraries: Ticket #7111: Switch case's default missing in date_time

attachment set

Tue, 10 Jul 2012 13:02:21 GMT

attachment → date_formatting.hpp_patch

Fix for the reported Bug.

Marshall Clow — Tue, 10 Jul 2012 14:20:48 GMT

I'm sorry, but I don't see the point of this change.

The code here is checking for all the possible values of the month_format_spec enum; there are no other (legal) values.

Also, your patch does not change the behavior of the code; if an invalid value was returned the by month_format(), the current code would do nothing, and your patch would change it so that it would ... do nothing.

Please tell me what you are trying to accomplish here.

P.S. I am completely missing what you mean by:

In case of default, code should break from the loop.

since I don't see a loop here.

severity changed

Wed, 11 Jul 2012 09:13:11 GMT

severity Problem → Cosmetic

I just want to highlight the coding practices. Its a cosmetic bug. In future if somebody add more cases, it will be easier for the user as code will be more readable and behavior of switch will be visible. Its obvious that it is still not doing anything, but the readability is more and it is according to coding guidelines.

cc, status, type changed; resolution set

viboes — Wed, 15 Aug 2012 13:53:30 GMT

cc viboes added
status new → closed
resolution → invalid
type Bugs → Feature Requests

There are too much work to do to clean up Boost.DateTime. Re-open if some tool is warning a bad usage.

status changed; resolution deleted

Tue, 25 Sep 2012 07:47:37 GMT

status closed → reopened
resolution invalid

If our application is using "Werror" flag, then if default case is not mentioned ,it is reported as an error.

Marshall Clow — Tue, 25 Sep 2012 19:06:32 GMT

Ok; I added a default case. But you should bug the gcc folks, since it's a bogus warning.

Marshall Clow — Tue, 25 Sep 2012 19:08:44 GMT

(In [80703]) Added default case label to silence bogus warning; Refs #7111

owner, status changed

Marshall Clow — Tue, 25 Sep 2012 19:11:14 GMT

owner changed from az_sw_dude to Marshall Clow
status reopened → new

Wed, 26 Sep 2012 03:09:14 GMT

Thanks Marshall, Please commit similar warning errors in Ticket# 7112 & 7113.

status changed; resolution set

Marshall Clow — Sun, 30 Sep 2012 23:25:27 GMT

status new → closed
resolution → fixed

(In [80797]) Merge bug fixes to release; Fixes #5550 Fixes #6136 Fixes #6513 Fixes #7111 Fixes #7112 Fixes #7113 Fixes #7342 Fixes #7426

Marshall Clow — Mon, 07 Jan 2013 19:39:36 GMT

BTW, clang now warns on this code.

Warning: default label in switch which covers all enumeration values [ -Wcovered-switch-default ]