Boost C++ Libraries: Ticket #7254: Proto expressions are not MPL sequences

Eric Niebler — Tue, 21 Aug 2012 18:04:28 GMT

I've wanted to do this, but there's a snag. MPL sequences use tag dispatching. You can get the tag of an MPL sequence either by specializing mpl::sequence_tag or by having a nested tag typedef in your sequence type. Neither is satisfactory for Proto.

Specializing mpl::sequence_tag is a non-starter because any type that uses proto::extends or BOOST_PROTO_EXTENDS can be a Proto expression. This is an open set.

Having a nested tag type is a non-starter because expressions are part of end-users' APIs, and Proto shouldn't be claiming such a common identifier for itself. Someone might want e.tag to mean something in their DSL.

BTW, Fusion doesn't have this problem because it uses fusion_tag instead of simply tag.

I'm open to suggestions.

Mathias Gaunard — Tue, 21 Aug 2012 18:23:15 GMT

I don't mind adding the tag in my expressions myself.

But typedef boost::fusion::fusion_sequence_tag tag; doesn't work.

It says there is no convert_impl for the proto expression tag.

Eric Niebler — Wed, 22 Aug 2012 17:14:39 GMT

The following works just fine for me:

#include <iostream>
#include <typeinfo>
#include <boost/proto/proto.hpp>
#include <boost/fusion/mpl.hpp>
#include <boost/mpl/for_each.hpp>
#include <boost/mpl/placeholders.hpp>
#include <boost/type_traits/remove_reference.hpp>
namespace mpl = boost::mpl;
namespace proto = boost::proto;
namespace fusion = boost::fusion;
template<class E>
struct my_expr;
struct my_domain
  : proto::domain<proto::generator<my_expr> >
{};
template<class E>
struct my_expr
  : proto::extends<E, my_expr<E>, my_domain>
{
    my_expr(E const &e = E())
      : proto::extends<E, my_expr<E>, my_domain>(e)
    {}
    typedef fusion::fusion_sequence_tag tag;
};
struct noop
{
    typedef void result_type;
    template<typename T>
    void operator()(T const &) const
    {
        std::cout << typeid(T).name() << std::endl;
    }
};
int main()
{
    my_expr<proto::terminal<int>::type> i;
    mpl::for_each<decltype(i + i), boost::remove_reference<mpl::_1> >(noop());
}

Mathias Gaunard — Wed, 22 Aug 2012 19:59:29 GMT

Try calling mpl::pop_back on that type, I get the following error:

invalid use of incomplete type `struct boost::fusion::extension::convert_impl<boost::proto::tagns_::tag::proto_expr>'

Eric Niebler — Wed, 22 Aug 2012 20:39:53 GMT

Interesting. Looks like an undocumented Fusion customization point. I can guess what it's supposed to do, but I'm following up on the boost list about it. At the very least, it's a bug in Fusion's docs. Let's wait and see what Joel says.

status changed

Eric Niebler — Tue, 28 Aug 2012 05:55:41 GMT

status new → assigned

Fixed on trunk in [80273].

status changed; resolution set

Eric Niebler — Mon, 03 Sep 2012 01:17:33 GMT

status assigned → closed
resolution → fixed