Boost C++ Libraries: Ticket #7270: C++11 narrowing problem in gil

attachment set

Jim Bosch — Thu, 23 Aug 2012 22:59:02 GMT

attachment → boost-gil-clang-c++11-narrowing.patch

updated patch that avoids introducing a new problem

Jim Bosch — Thu, 23 Aug 2012 23:00:15 GMT

Looking closer, my original patch would solve the problem but probably create some new ones, by always casting to unsigned int instead of the template parameter type. I've now attached a new patch that avoids mistake.

It also looks like one of the partial specializations of the template in the same area could cause problems for C++11, depending on the types it was instantiated with. I'll leave fixing that up to someone more familiar with its purpose.

status changed; resolution set

chhenning — Mon, 04 Feb 2013 19:28:27 GMT

status new → closed
resolution → fixed

This has been fixed. See ticket 7970

status, version changed; resolution deleted

babatakao@… — Fri, 09 Dec 2016 01:59:01 GMT

status closed → reopened
version Boost 1.51.0 → Boost 1.63.0
resolution fixed

boost 1.61 still causes the error with clang: Apple LLVM version 7.3.0 (clang-703.0.31)

/buildroot/libs/boost/include/boost/gil/channel_algorithm.hpp:55:85: error: non-type template argument evaluates to -1, which cannot be narrowed to type 'unsigned long' [-Wc++11-narrowing]
struct unsigned_integral_max_value : public mpl::integral_c<UnsignedIntegralChannel,-1> {};
                                                                                    ^
/buildroot/libs/boost/include/boost/gil/channel_algorithm.hpp:55:85: /libs/boost/include/boost/gil/channel_algorithm.hpp:205:19: note: in instantiation of template class 'boost::gil::detail::unsigned_integral_max_value<unsigned long>' requested here
        if (src > unsigned_integral_max_value<uintmax_t>::value - div2)
                  ^
1 error generated.

and it does not seem to be fixed on boost 1.63.0 beta1.

(The error occurs only if "-std=c++11" is given.)

"boost-gil-clang-c++11-narrowing.patch" fixes the error.

cc set

Mateusz Loskot — Thu, 16 Feb 2017 10:51:18 GMT

cc mateusz@… added

owner, status changed

Stefan Seefeld — Sat, 01 Jul 2017 21:14:32 GMT

owner changed from Hailin Jin to Stefan Seefeld
status reopened → new

owner, status changed

Mateusz Loskot — Mon, 09 Apr 2018 15:15:09 GMT

owner changed from Stefan Seefeld to Mateusz Loskot
status new → assigned

status changed; resolution set

Mateusz Loskot — Mon, 09 Apr 2018 15:15:46 GMT

status assigned → closed
resolution → fixed

This should have been fixed by https://github.com/boostorg/gil/commit/e3cba43c16e1958e8dac1ca9cb5745d9d6a68068 (Feb 6, 2013)

milestone changed

Mateusz Loskot — Mon, 09 Apr 2018 15:18:36 GMT

milestone To Be Determined → Boost 1.68.0