Boost C++ Libraries: Ticket #7272: win32/thread_primitives.hpp: (Unneccessary) Warning

attachment set

christian.buss@… — Fri, 24 Aug 2012 09:44:54 GMT

attachment → thread_primitives.hpp.diff

Diff for suggested fix.

viboes — Fri, 24 Aug 2012 22:22:13 GMT

In order to avoid the unnecessary assignation for all the compilers I think it is better to apply it conditionally. In addition the current code causing the warning was there for Intel compiler, so the attached patch should work.

attachment set

anonymous — Fri, 24 Aug 2012 22:23:03 GMT

attachment → 7272.patch

owner, status, version changed

viboes — Fri, 24 Aug 2012 22:24:01 GMT

owner changed from Anthony Williams to viboes
status new → assigned
version Boost 1.52.0 → Boost 1.51.0

milestone changed

viboes — Sun, 26 Aug 2012 13:02:27 GMT

milestone To Be Determined → Boost 1.52.0

Committed in trunk at [80203]

viboes — Sun, 26 Aug 2012 13:07:01 GMT

Committed in trunk at [80235]

status changed; resolution set

viboes — Sun, 09 Sep 2012 13:32:02 GMT

status assigned → closed
resolution → fixed

Merged to release [80450]

attachment set

gix — Fri, 28 Sep 2012 21:32:14 GMT

attachment → boost-7272.cpp

test-case

status, severity changed; resolution deleted

gix — Fri, 28 Sep 2012 21:37:33 GMT

status closed → reopened
resolution fixed
severity Cosmetic → Problem

The warning reported by ICL points at a serious bug. Changesets [80203] and [80235] only silence the warning.

ICL seems to only accept newlines as separator between asm instructions and only emits "mov eax,bit", which makes interlocked_bit_test_and_set return an ret uninitialized.

Running the attached test case:

$ icl -nologo -EHsc boost-7272.cpp && boost-7272.exe
boost-7272.cpp
Testing bit 0 of x=3
result: 0 (expected: 1)
x:      3 (expected: 3)
Testing bit 2 of x=3
result: 0 (expected: 0)
x:      3 (expected: 7)

As a comparison, here with MSVC:

D:\>cl -nologo -EHsc boost-7272.cpp && boost-7272.exe
boost-7272.cpp
Testing bit 0 of x=3
result: 1 (expected: 1)
x:      3 (expected: 3)
Testing bit 2 of x=3
result: 0 (expected: 0)
x:      7 (expected: 7)

Putting each instruction on a separate line (with and without trailing ";") fixes this.

attachment set

gix — Fri, 28 Sep 2012 21:49:55 GMT

attachment → boost-7272-proper.patch

Proper patch, reformats asm instructions

viboes — Sat, 29 Sep 2012 16:53:47 GMT

Committed in trunk revision [80757].

milestone deleted

viboes — Tue, 09 Oct 2012 23:38:15 GMT

milestone Boost 1.52.0

status changed; resolution, milestone set

viboes — Thu, 11 Oct 2012 15:59:28 GMT

status reopened → closed
resolution → fixed
milestone → Boost 1.52.0

Merged revision 80955.