Boost C++ Libraries: Ticket #7296: Bug-fix and improvements to test utility functions

attachment set

Mon, 27 Aug 2012 16:03:02 GMT

attachment → utils.patch

Patch file for utils.hpp

attachment set

Mon, 27 Aug 2012 16:03:39 GMT

attachment → utils.hpp

The new (i.e., already patched) utils.hpp

Mon, 27 Aug 2012 21:08:42 GMT

The previously attached patch contained simpler macros but some output messages was less informative (for the user). Now, with the new attached patch utils-new.patch, those output messages are again informative.

Sorry for the inconvenience.

attachment set

Mon, 27 Aug 2012 21:09:31 GMT

attachment → utils-new.patch

New patch file for utils.hpp

attachment set

Mon, 27 Aug 2012 21:10:25 GMT

attachment → utils.2.hpp

The new (i.e., already patched by utils-new.patch) utils.hpp

Gunter — Mon, 27 Aug 2012 22:13:28 GMT

(In [80267]) boost/numeric/ublas/triangular.hpp - applied patch, see #4024 libs/numeric/ublas/test/test_inplace_solve.cpp - fixed includes

libs/numeric/ublas/test/utils.hpp - applied patch (after s/BOOST_UBLA_TEST/BOOST_UBLAS_TEST/g), see #7296

Tue, 28 Aug 2012 07:30:30 GMT

The previous patch file utils-new.patch contained bad macro names: BOOST_UBLA_TEST_CHECK_EQ and BOOST_UBLA_TEST_CHECK_EQUAL. Specifically, UBLA_ should be UBLAS_. The new attached patch fix this.

I attach two patches:

utils-201208280915.patch is the patch file to be used if applied against the original (unpatched) utils.hpp (i.e., the one you find in the actual boost trunk).
utils-201208280915.patch is the patch file to be used if applied against the patched utils.hpp (i.e., the ones named utils.2.hpp in the above attachments).

As before, I also attach the new (patched) version of utils.hpp.

Again, sorry for this inconvenience, and thanks to guwi17 for pointing it out.

attachment set

Tue, 28 Aug 2012 07:31:51 GMT

attachment → utils-201208280915.patch

Patch file for utils.hpp to be applied against the version you currently find in boost trunk

attachment set

Tue, 28 Aug 2012 07:33:43 GMT

attachment → utils_UBLA_UBLAS-201208280915.patch

Patch file for utils.hpp to be applied against the version of utils.hpp patched with utils-new.patch (i.e., the one named utils.2.hpp)

attachment set

Tue, 28 Aug 2012 07:34:34 GMT

attachment → utils.3.hpp

The new (i.e., already patched by utils-201208280915.patch) utils.hpp file.

Tue, 28 Aug 2012 07:35:32 GMT

In the last my comment, read the second utils-201208280915.patch as utils_UBLA_UBLAS-201208280915.patch.

Tue, 28 Aug 2012 19:59:20 GMT

To date, some macros in utils.hpp fail when the value type has a complex type.

I've tried to fix it and to test the fix I have created a test-suite for the macros contained in utils.hpp.

I'm going to upload the patch file together with the test suite.

attachment set

Tue, 28 Aug 2012 20:11:24 GMT

attachment → utils-fix_complex-201208281922.patch

Patch file for utils.hpp to make it works with complex numbers. To be applied to the version of utils.hpp in the current boost trunk.

attachment set

Tue, 28 Aug 2012 20:12:33 GMT

attachment → utils.4.hpp

The new utils.hpp file that you should obtain after applying the utils-fix_complex-201208281922.patch patch.

attachment set

Tue, 28 Aug 2012 20:13:34 GMT

attachment → test_ticket7296.cpp

Test case for utils.hpp. It also shows that now utils.hpp works with complex value types.

Thu, 30 Aug 2012 08:49:16 GMT

I've tried to make some macro more robust to complex expressions by using (when needed) macro expansion inside parenthesis. Furthermore,

I fixed a bug: I forgot to add an increment of the variable used to count test failures
I added two more macros for performing relative closeness comparison in case of vectors and matrices
I replaced the use of unsigned long with std::size_t (I think it's better)
I enhanced the doc

As usual, I add the new patch file (wrt utils.4.hpp) together with the whole new utils.hpp file and the updated test-case.

attachment set

Thu, 30 Aug 2012 08:50:25 GMT

attachment → utils-201208301042.patch

Patch file for utils.hpp to be applied against utils.4.hpp

attachment set

Thu, 30 Aug 2012 08:51:31 GMT

attachment → utils.5.hpp

The new patched utils.hpp (i.e., the one resulting after applying patch utils-201208301042.patch)

attachment set

Thu, 30 Aug 2012 08:52:38 GMT

attachment → test_ticket7296.2.cpp

The updated test_ticket7296.cpp for the new version of utils.hpp named utils.5.hpp

Gunter — Mon, 10 Sep 2012 20:50:13 GMT

(In [80483]) boost/numeric/ublas/traits.hpp, libs/numeric/ublas/test/test_assignment.cpp, libs/numeric/ublas/test/begin_end.cpp: see #7296, fix test issues with unsigned integer types

Gunter — Mon, 10 Sep 2012 21:08:53 GMT

(In [80485])