Boost C++ Libraries: Ticket #7353: no newline at end of file

description changed

viboes — Sat, 03 Nov 2012 01:49:07 GMT

description modified (diff)

status changed; resolution set

Joel de Guzman — Sat, 03 Nov 2012 23:35:52 GMT

status new → closed
resolution → worksforme

I can't reproduce this. I looked at the files you mention but I don't see any missing newlines at the end. I looked at the files in both Linux, Mac and Windows. My guess is that you've got a problem when obtaining the source? I'm not sure.

Please investigate further. The problem does is not in Boost, as far as I can tell.

work@… — Sat, 09 Feb 2013 22:47:35 GMT

Hi, I have the exact same problem.

boost/fusion/tuple/detail/preprocessed/tuple.hpp:21:7: warning: no newline at end of file

I got the source (boost_1_53_0.tar.bz2) from sourceforge. Built an installed standard (./bootstrap.sh --prefx=/my/pfix ; ./b2 install).

I checked the file and it seems to be autogenerated, and really, the last character on the file is the "f" from #endif. Here's the file

/*=============================================================================
    Copyright (c) 2001-2011 Joel de Guzman
    Distributed under the Boost Software License, Version 1.0. (See accompanying
    file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
    This is an auto-generated file. Do not edit!
==============================================================================*/
#if FUSION_MAX_VECTOR_SIZE <= 10
#include <boost/fusion/tuple/detail/preprocessed/tuple10.hpp>
#elif FUSION_MAX_VECTOR_SIZE <= 20
#include <boost/fusion/tuple/detail/preprocessed/tuple20.hpp>
#elif FUSION_MAX_VECTOR_SIZE <= 30
#include <boost/fusion/tuple/detail/preprocessed/tuple30.hpp>
#elif FUSION_MAX_VECTOR_SIZE <= 40
#include <boost/fusion/tuple/detail/preprocessed/tuple40.hpp>
#elif FUSION_MAX_VECTOR_SIZE <= 50
#include <boost/fusion/tuple/detail/preprocessed/tuple50.hpp>
#else
#error "FUSION_MAX_VECTOR_SIZE out of bounds for preprocessed headers"
#endif

anonymous — Mon, 11 Feb 2013 10:50:03 GMT

Confirmed. There must've been something wrong with the way the trunk got merged into release. Trunk is just fine. I'll make sure this gets merged correctly when I do the next merge to release.

status, version changed; resolution deleted

Wed, 18 Dec 2013 23:48:14 GMT

status closed → reopened
version Boost 1.50.0 → Boost 1.55.0
resolution worksforme

Reopening, as this has still not been resolved. I just pulled down 1.55 (boost_1_55_0.tar.bz2) and built for OS X. Still no newline at end of file.

For reference here is my boost/fusion/tuple/detail/preprocessed/tuple.hpp:

/*=============================================================================
    Copyright (c) 2001-2011 Joel de Guzman
    Distributed under the Boost Software License, Version 1.0. (See accompanying
    file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
    This is an auto-generated file. Do not edit!
==============================================================================*/
#if FUSION_MAX_VECTOR_SIZE <= 10
#include <boost/fusion/tuple/detail/preprocessed/tuple10.hpp>
#elif FUSION_MAX_VECTOR_SIZE <= 20
#include <boost/fusion/tuple/detail/preprocessed/tuple20.hpp>
#elif FUSION_MAX_VECTOR_SIZE <= 30
#include <boost/fusion/tuple/detail/preprocessed/tuple30.hpp>
#elif FUSION_MAX_VECTOR_SIZE <= 40
#include <boost/fusion/tuple/detail/preprocessed/tuple40.hpp>
#elif FUSION_MAX_VECTOR_SIZE <= 50
#include <boost/fusion/tuple/detail/preprocessed/tuple50.hpp>
#else
#error "FUSION_MAX_VECTOR_SIZE out of bounds for preprocessed headers"
#endif

Last character is "f", not newline.

And this is my build command, in case it matters:

./bootstrap.sh
./b2 -a toolset=clang cxxflags="-std=c++11" link=static variant=release address-model=64 architecture=x86 threading=multi runtime-link=static --without-math --without-graph --without-wave -sZLIB_SOURCE="../../../../zlib-1.2.7" --stagedir=./Mac106/build/Release stage

Tue, 23 Sep 2014 08:14:14 GMT

Where is this generated from, as this file appears to be in the tar file rather than being rebuilt.

cc set

Wed, 24 Sep 2014 10:45:10 GMT

cc ttanner2@… added

status changed; resolution set

Kohei Takahashi — Tue, 11 Oct 2016 16:26:08 GMT

status reopened → closed
resolution → fixed

I have no OS X machine but it seems already to be fixed. https://github.com/boostorg/fusion/commit/b6142f16133b21ee0c5e9c8ec48646f2654e74b4

habdank@… — Wed, 19 Oct 2016 20:30:48 GMT

Thanks a lot for fixing it.

EOL at the end of header file is very old requirement which comes from C, but I think it is also better for readability, when the code ends with new line.