Boost C++ Libraries: Ticket #7408: istream_range should not pull istream

version, component changed; owner set

viboes — Sat, 22 Sep 2012 19:31:55 GMT

owner set to Neil Groves
version Boost 1.52.0 → Boost 1.51.0
component None → range

Nathan Ridge — Wed, 05 Jun 2013 00:55:39 GMT

(In [84644]) [range] Don't include <istream> unnecessarily in istream_range.hpp (refs #7408).

Nathan Ridge — Wed, 05 Jun 2013 00:57:27 GMT

Fixed in trunk. However, I'm not convinced that this accomplishes anything, as istream_range.hpp includes <iterator> to use istream_iterator, and <iterator> most likely needs to bring in <istream> to properly define istream_iterator (since it's a template class so its methods need to be defined in the header). libstdc++'s <iterator>, for example, brings in <istream>.

status changed; resolution set

Nathan Ridge — Tue, 18 Jun 2013 02:22:09 GMT

status new → closed
resolution → fixed

(In [84823]) [range] Merge Boost.Range bug fixes to release branch (fixes #6944; fixes #7407; fixes #7408; fixes #7731; fixes #7827; fixes #8338; fixes #8453).

Nathan Ridge — Tue, 18 Jun 2013 02:23:14 GMT

Fixed for 1.54.

ne01026@… — Wed, 19 Jun 2013 18:09:03 GMT

Replying to nathanridge:

Fixed in trunk. However, I'm not convinced that this accomplishes anything, as istream_range.hpp includes <iterator> to use istream_iterator, and <iterator> most likely needs to bring in <istream> to properly define istream_iterator (since it's a template class so its methods need to be defined in the header). libstdc++'s <iterator>, for example, brings in <istream>.

#include <iterator>
void foo (::std ::wistream & = ::std ::wcin);

error: ‘wcin’ is not a member of ‘std’ (good!)

Nathan Ridge — Wed, 19 Jun 2013 18:18:29 GMT

Replying to ne01026@…:

Replying to nathanridge:

Fixed in trunk. However, I'm not convinced that this accomplishes anything, as istream_range.hpp includes <iterator> to use istream_iterator, and <iterator> most likely needs to bring in <istream> to properly define istream_iterator (since it's a template class so its methods need to be defined in the header). libstdc++'s <iterator>, for example, brings in <istream>.
#include <iterator>
void foo (::std ::wistream & = ::std ::wcin);
error: ‘wcin’ is not a member of ‘std’ (good!)

That would be because 'wcin' is defined in <iostream>, not <istream>, and <iterator> doesn't bring in <iostream>, only <istream>. istream_range.hpp has never brought in <iostream>, either, so I don't see how this is relevant.