Boost C++ Libraries: Ticket #7435: Crash with format using UTF16 strings on MacOS X

attachment set

Thu, 27 Sep 2012 08:38:27 GMT

attachment → format-imbue.diff

Steven Watanabe — Thu, 14 Feb 2013 01:56:40 GMT

Looking around in the code it appears that stream_format_state::apply_on itself calls oss.imbue. It isn't clear to me why this is crashing, but it seems to me that if apply_on fails if the locale isn't set, the simplest solution is to set the locale first rather than setting it in put only for to overwrite it immediately.

Thu, 14 Feb 2013 11:30:36 GMT

The fix wasn't done by me, but I know that the crash happens when boost::format is used during app startup (e.g. during the initialization of static members). This may be related to the usage of unsigned short as character type or due to initialization order problems.

If you have a better way to fix the issue, we're fine with this.

Joachim Faulhaber — Fri, 22 Feb 2013 15:51:44 GMT

At the tagged code line, the program crashes. I does not crash, if os.imbue(*loc_default); is called before.

boost/format/internals.hpp(104):
    template<class Ch, class Tr>
    void stream_format_state<Ch,Tr>:: apply_on (basic_ios & os,
                      boost::io::detail::locale_t * loc_default) const {
        // set the state of this stream according to our params
        if(width_ != -1)
            os.width(width_);
        if(precision_ != -1)
            os.precision(precision_);
        if(fill_ != 0)
            os.fill(fill_); //<== crashes here
        os.flags(flags_);
        os.clear(rdstate_);
        os.exceptions(exceptions_);
#if !defined(BOOST_NO_STD_LOCALE)
        if(loc_)
            os.imbue(loc_.get());
        else if(loc_default)
            os.imbue(*loc_default);
#else
        (void) loc_default; // keep compiler quiet if we don't support locales
#endif        
    }

So we only need to move the bottom code (between #if and #end) to the beginning of the function. This change is done in the attached patch-file internals.hpp.patch. If there are no objections against this patch, I will apply it.

attachment set

Joachim Faulhaber — Fri, 22 Feb 2013 17:43:58 GMT

attachment → internals.hpp.patch

owner, status changed

James E. King, III — Sat, 14 Oct 2017 12:13:37 GMT

owner changed from Samuel Krempp to James E. King, III
status new → assigned

This was fixed in the 1.60.0 release: https://github.com/boostorg/format/commit/6fd5847729f07d6f31d37ac3b2d37e78b6689997

Once I have maintainer access I will uupdate the milestone accordingly.

milestone changed

James E. King, III — Wed, 18 Oct 2017 19:18:10 GMT

milestone To Be Determined → Boost 1.61.0

status changed; resolution set; milestone deleted

James E. King, III — Tue, 24 Oct 2017 18:34:57 GMT

status assigned → closed
resolution → fixed
milestone Boost 1.61.0

I can't set the milestone appropriately, but it was fixed some time ago, so I am marking it fixed.