Boost C++ Libraries: Ticket #7526: zip_iterator does not support std::tuple and std::pair

attachment set

claas.koehler@… — Thu, 18 Oct 2012 10:06:54 GMT

attachment → zip_iterator_diff.txt

diff of the patched zip_iterator file compared to the 1.50.0 version

attachment set

claas.koehler@… — Thu, 18 Oct 2012 11:44:39 GMT

attachment → zip_iterator_diff.2.txt

diff of the patched zip_iterator file compared to the 1.50.0 version

cc set

Thu, 18 Oct 2012 12:06:44 GMT

cc flast@… added

How about use Boost.Fusion instead of Boost.Tuple? I'll attach 5 patches.

First, bug7513.patch fixes #7513.
boost_tuple-convert.patch adapts Boost.Tuple to Boost.MPL algorithms via Boost.Fusion.
std_tuple-convert.patch similar to above one, but for std::tuple.
zip_iterator.patch is main patch of this changes: rebase impl of zip_iterator to Boost.Fusion.
Finally, std_pair-specialization.patch is specialization for std::pair.

This changes have backward compatibility: iterator/zip_iterator.hpp includes fusion/adapted/boost_tuple.hpp implicitly.

attachment set

Thu, 18 Oct 2012 12:07:15 GMT

attachment → bug7513.patch

attachment set

Thu, 18 Oct 2012 12:07:32 GMT

attachment → boost_tuple-convert.patch

attachment set

Thu, 18 Oct 2012 12:07:48 GMT

attachment → std_tuple-convert.patch

attachment set

Thu, 18 Oct 2012 12:08:08 GMT

attachment → zip_iterator.patch

attachment set

Thu, 18 Oct 2012 12:08:20 GMT

attachment → std_pair-specialization.patch

Dave Abrahams — Thu, 18 Oct 2012 14:33:42 GMT

FYI, there's a branch or tag somewhere way back in SVN history that does (mostly) the same thing. At the time, I think there were reasons not to apply it, and by now it's probably out-of-sync with Fusion in some subtle way, but it was well-organized at least, so it might be worth a look if you can find it.

jeffrey.hellrung — Fri, 19 Oct 2012 02:31:35 GMT

Re Fusion, I was thinking the same thing. Will have to take a closer look at the patches in the future to see if they align with what I'm thinking. And thanks for the FYI, Dave.

owner changed

Dave Abrahams — Wed, 21 Nov 2012 22:40:28 GMT

owner changed from Dave Abrahams to jeffrey.hellrung

Sun, 04 May 2014 15:30:48 GMT

Is there a target version for which these patches will be applied? Compatibility with std::tuple would be a very important feature to have, especially since compiler support for C++11 is now more widespread.

anonymous — Sun, 25 May 2014 19:36:22 GMT

Is there an ETA for when this gets applied?

Tue, 27 May 2014 03:43:33 GMT

Which do you think is better, claas.koehler's patch or Re Fusion?

claas.koehler@… — Tue, 27 May 2014 07:24:19 GMT

I think the general agreement was, that the Fusion Patch is preferable, since my patch constitutes a quick and dirty solution only. That's why I never took any further attempts in submitting tests.

However, since the Fusion patch has not been released, I have been using my version privately for quite a while now and patched every version of my local boost, because I require the functionality in several projects. I would prefer to stop doing this as soon as possible, of course.

Maybe it would be good to poll in boost devel mailing list, why the patch has not been applied so far and then take the necessary steps to finally get it into production.

My personal preference would be to apply Kohei Takashi's patch with the necessary testing, if it is working, regardless of any other old versions (see Jeffrey's comment 20 months ago). A good solution today is definitely better than a perfect one in another 20 months from my point of view.

Regards Claas

Thu, 29 May 2014 03:12:06 GMT

OK. Now, I'm working for reimplementing zip_iterator as fusion based one in following branches.

ttps://github.com/Flast/fusion/tree/pr/adapt/tuple
ttps://github.com/Flast/iterator/tree/pr/zip_iterator/fusionize

However, I have no idea for fusion::convert for non variadic template based std::tuple (i.e. msvc 11.0 or earlier). So, I will spent a little time to send PR.

Sat, 14 Jun 2014 07:17:43 GMT

I've submitted about Fusion based zip_iterator. Please review it.

https://github.com/boostorg/iterator/pull/2

Edward Diener — Sun, 23 Aug 2015 12:56:18 GMT

I have looked at the PR but found a problem when using the fusion container deque. Please take a look at my comments in the PR. I would like to move ahead with the PR, as I think it is valuable to allow this change, but I need a clarification of why it is failing with the fusion deque.

edaskel@… — Sun, 12 Mar 2017 23:21:41 GMT

Looks like this has been fixed :) Close?

Edward Diener — Thu, 23 Mar 2017 09:40:24 GMT

Yes, this has been fixed and should appear in upcoming release.

anonymous — Fri, 16 Mar 2018 12:12:51 GMT

edaskel@… — Fri, 16 Mar 2018 18:40:55 GMT

Let's close this "fixed" :)