Boost C++ Libraries: Ticket #7610: Add support for PSK authentication to boost::asio:ssl

attachment set

Tue, 30 Oct 2012 16:51:59 GMT

attachment → boost-psk-patch.diff

PSK support for boost::asio::ssl

diego.duclos@… — Fri, 20 Jun 2014 20:28:26 GMT

Is there any update on this issue ? I'd find this very much useful as well, and I've merged this into the 1.55.0 version of boost if a more recent patch is wanted.

anonymous — Fri, 06 Mar 2015 09:56:02 GMT

I would also find this useful! I guess the main issue is that the PSK callback from OpenSSL is synchronous..

anonymous — Fri, 06 Mar 2015 09:56:18 GMT

I would also find this useful! I guess the main issue is that the PSK callback from OpenSSL is synchronous..

anonymous — Fri, 06 Mar 2015 20:56:23 GMT

The patch has a couple of issues with it. Chiefly the use of SSL_ctx_set_app_data and SSL_ctx_get_app_data (and SSL_set_app_data in the engine class) assigning a different type to set_verify_callback. the type set in verify_callback is the one that is destroyed in the context dtor. It will probably still work but it is technically not correct. Additionally this would result in UB if both verify_callback and psk callbacks are set on the same context.

Should use a small detailcontext_appdata class or something.

This is also missing an interface to set the PSK callback in the client case.

anonymous — Fri, 06 Mar 2015 20:56:49 GMT

Should use a small detailcontext_appdata class or something.

This is also missing an interface to set the PSK callback in the client case.

anonymous — Fri, 06 Mar 2015 20:58:00 GMT

The patch has a couple of issues with it. Chiefly the use of SSL_ctx_set_app_data and

SSL_ctx_get_app_data (and SSL_set_app_data in the engine class) assigning a different type to

set_verify_callback. the type set in verify_callback is the one that is destroyed in the context

dtor. It will probably still work but it is technically not correct. Additionally this would result

in UB if both verify_callback and psk callbacks are set on the same context.

Should use a small detailcontext_appdata class or something.

This is also missing an interface to set the PSK callback in the client case.