Boost C++ Libraries: Ticket #7784: [PATCH] Overlapping strings are not properly handled by string::algo::find_all

attachment set

cedstrom@… — Tue, 11 Dec 2012 07:34:22 GMT

attachment → OverlappingStringTest.cpp

Overlapping String Test Case

anonymous — Thu, 20 Dec 2012 09:59:00 GMT

Patch which I believe fixes this:

Index: boost-trunk/boost/algorithm/string/find_iterator.hpp
===================================================================
--- boost-trunk/boost/algorithm/string/find_iterator.hpp	(revision 82112)
+++ boost-trunk/boost/algorithm/string/find_iterator.hpp	(working copy)
@@ -132,7 +132,10 @@
             // increment
             void increment()
             {
-                m_Match=this->do_find(m_Match.end(),m_End);
+                if(m_Match.begin() == m_Match.end())
+                    m_Match=this->do_find(m_Match.end(),m_End);
+                else
+                    m_Match=this->do_find(m_Match.begin()+1,m_End);
             }
             // comparison

summary changed

anonymous — Thu, 20 Dec 2012 09:59:22 GMT

summary Overlapping strings are not properly handled by string::algo::find_all → [PATCH] Overlapping strings are not properly handled by string::algo::find_all

Marshall Clow — Thu, 20 Dec 2012 16:28:34 GMT

Applied patch and added test case in [82117]. Thanks for the patch!

status changed; resolution set

Marshall Clow — Wed, 02 Jan 2013 18:40:43 GMT

status new → closed
resolution → fixed

In [82238] merge fix to release.

status changed; resolution deleted

Steven Watanabe — Mon, 04 Mar 2013 16:20:52 GMT

status closed → reopened
resolution fixed

Marshall, I don't think that this patch should have been applied. I believe that the library is intended to return non-overlapping matches. Rationale: (1) find_all is in split.hpp, the documentation says: "Split algorithms can be used to divide a string into several parts...." (2) For the sake of consistency, find_all, replace_all, and erase_all, should all use the same set of matches. The patch breaks this. (3) boost::regex_iterator also finds non-overlapping matches.

Marshall Clow — Mon, 09 Sep 2013 18:02:35 GMT

This fix broke other stuff. See #9063.

I'm considering reverting it.

If you have objections, now would be a good time to speak up.

status changed; resolution set

Marshall Clow — Tue, 08 Oct 2013 17:54:23 GMT

status reopened → closed
resolution → invalid

No one complained.

Reverting this.