Boost C++ Libraries: Ticket #7856: pop_front() and pop_back() docs missing

Dave Abrahams — Fri, 04 Jan 2013 21:13:02 GMT

OK, but the names (at least the ones that get documented) should be changed to drop_front and drop_back. pop_xxx implies the element is getting destroyed.

status, milestone changed

Neil Groves — Tue, 04 Mar 2014 13:12:49 GMT

status new → assigned
milestone To Be Determined → Boost 1.56.0

That's a great suggestion. I used the names from the Alexandrescu work, but this is better.

Tue, 04 Mar 2014 13:48:12 GMT

I like pop_ better, especially as existing code is already using it. The type already indicates it's not actually destroying elements. Just like pop_back() for a vector<T*>.

status changed; resolution set

Neil Groves — Tue, 04 Mar 2014 20:42:05 GMT

status assigned → closed
resolution → fixed

I much prefer drop_front and drop_back as it avoids accidentally modifying containers. While I appreciate the frustration of having to modify your code it is a small change to functions that were not documented.

I've modified all of my code that uses these functions in the space of half an hour. I hope that the increased work that you incur is small too.

I've renamed the functions and added tests for these.

Tue, 04 Mar 2014 20:57:35 GMT

I'll survive, do the required #ifdef's based on BOOST_VERSION probably won't be pretty.

Tue, 04 Mar 2014 20:57:49 GMT

though*