Boost C++ Libraries: Ticket #7875: BOOST_THREAD_THROW_IF_PRECONDITION_NOT_SATISFIED should not be enabled by default

attachment set

Thu, 10 Jan 2013 12:19:23 GMT

attachment → Jamfile.v2.patch

Stop enabling BOOST_THREAD_THROW_IF_PRECONDITION_NOT_SATISFIED by default

viboes — Thu, 10 Jan 2013 12:50:44 GMT

Yes, this is abug on 1.52. Version 1.53 lets all (almost all) the uses of BOOST_THREAD_THROW_IF_PRECONDITION_NOT_SATISFIED on the header files

E.g. the thread::join function is defined on boost/detail/thread.hpp as follows

    void thread::join() {
        if (this_thread::get_id() == get_id())
          boost::throw_exception(thread_resource_error(system::errc::resource_deadlock_would_occur, "boost thread: trying joining itself"));
        BOOST_THREAD_VERIFY_PRECONDITION( join_noexcept(),
            thread_resource_error(system::errc::invalid_argument, "boost thread: thread not joinable")
        );
    }

I will however comment the Jamfile.v2 line

<define>BOOST_THREAD_THROW_IF_PRECONDITION_NOT_SATISFIED

owner, status changed

viboes — Thu, 10 Jan 2013 12:51:04 GMT

owner changed from Anthony Williams to viboes
status new → assigned

Thu, 10 Jan 2013 13:28:31 GMT

Thanks for the quick response Vicente! Glad to hear you're planning to change it. Have you looked at #7668 yet? I'm not sure if Trac notifies you when comments are added to a closed ticket, but I'm pretty sure your fix to thread_group::join_all() has a race condition.

milestone changed

viboes — Sat, 12 Jan 2013 10:00:49 GMT

milestone To Be Determined → Boost 1.53.0

Changeset [82436] by viboes

status changed; resolution set

viboes — Mon, 14 Jan 2013 17:21:23 GMT

status assigned → closed
resolution → fixed

Committed revision 82491.