Boost C++ Libraries: Ticket #7905: boost::math::policies::raise_rounding_error returns the wrong min/max values for ignore_error and errno_on_error

benkerby@… — Fri, 18 Jan 2013 23:26:46 GMT

Note that the function reads:

   // This may or may not do the right thing, but the user asked for the error
   // to be ignored so here we go anyway:
   return std::numeric_limits<T>::is_specialized ? (val > 0 ? (std::numeric_limits<T>::max)() : -(std::numeric_limits<T>::max)()): val;

but it should read

   // This may or may not do the right thing, but the user asked for the error
   // to be ignored so here we go anyway:
   return std::numeric_limits<TargetType>::is_specialized ? (val > 0 ? (std::numeric_limits<TargetType>::max)() : (std::numeric_limits<TargetType>::min)()): val;

Two changes:

template specialized on the TargetType
return the minimum value rather than the negative version of the max value (important for unsigned types)

component changed; owner set

benkerby@… — Fri, 18 Jan 2013 23:29:04 GMT

owner set to John Maddock
component None → math

status changed

John Maddock — Wed, 13 Feb 2013 19:06:21 GMT

status new → assigned

Confirmed, testing fix.

status changed; resolution set

John Maddock — Thu, 14 Feb 2013 18:20:06 GMT

status assigned → closed
resolution → fixed

(In [82885]) Fix raise_rounding_error to return the correct result (and type) when an error occurs. Fixes #7905.