Boost C++ Libraries: Ticket #7979: atomic library compilation error on 1.53.0

attachment set

victor.hiairrassary.ml@… — Tue, 05 Feb 2013 12:15:31 GMT

attachment → boost_compilation_log

atomic compilation log

version changed

timblechmann — Tue, 05 Feb 2013 12:26:57 GMT

version Boost 1.52.0 → Boost 1.53.0

related to #7823, we basically just work around that bug manually.

victor, i don't have a uclibc toolchain on my system, but can you try to change

defined(_XOPEN_UNIX) && (_XOPEN_UNIX+0 > 0)

defined(_XOPEN_UNIX) && (_XOPEN_UNIX+0 > 0) && !defined(__UCLIBC__)

victor.hiairrassary.ml@… — Tue, 05 Feb 2013 12:44:59 GMT

Thanks, this works fine (compilation finished successfully)!

Will you commit it?

status changed; resolution set

timblechmann — Tue, 05 Feb 2013 21:43:07 GMT

status new → closed
resolution → fixed

(In [82754]) atomic: uclibc doesn't seem to have intptr_t

fixes #7979

victor.hiairrassary.ml@… — Wed, 06 Feb 2013 07:09:39 GMT

Thanks, but I don't agree so much with your commit, at least with your comment : indeed, uClibc have stdint.h file, which declare intptr_t and uintptr_t (see http://git.uclibc.org/uClibc/tree/include/stdint.h at line 118).

So, maybe, there is a better way to solve this issue.

timblechmann — Wed, 06 Feb 2013 08:48:12 GMT

the correct way to solve it is to use <boost/cstdint.hpp> and boost::intptr_t ... however apparently that is broken and undermaintained, so we just work around this. unfortunately uclibc doesn't seem to be covered by the automatic tests, so i'd prefer to exclude functionality to be on the safe side

victor.hiairrassary.ml@… — Thu, 07 Feb 2013 15:02:16 GMT

I understand the problem!

Thanks for your answer!

david.heidelberger@… — Sat, 19 Oct 2013 23:13:29 GMT

I having this problem with "boost/atomic/atomic.hpp:166:16: error: ‘uintptr_t’ was not declared in this scope". boost-1.53.0, glibc 2.18, gcc 4.9_20131013.

./boost/atomic/atomic.hpp:166:16: error: ‘uintptr_t’ was not declared in this scope ./boost/atomic/atomic.hpp:166:25: error: template argument 1 is invalid ./boost/atomic/atomic.hpp:166:43: error: invalid type in declaration before ‘’ token

hongli@… — Sun, 27 Oct 2013 17:41:43 GMT

I confirm david.heidelberger's problem. I can reproduce it on today's Arch Linux release (2013-10-27), g++ 4.8.2, Boost 1.54.0, glibc instead of ulibc.

The problem is still related to the _XOPEN_UNIX definition. It causes atomic.h to typedef "atomic<uintptr_t> atomic_uintptr_t". However, uintptr_t is not defined. This is because boost/cstdint.hpp does not include stdint.h due to this line:

#if defined(BOOST_HAS_STDINT_H) && (!defined(GLIBC)

defined(GLIBC_HAVE_LONG_LONG))

I don't know what's the proper way to fix this problem. Defining GLIBC_HAVE_LONG_LONG works along the problem though.

By the way, there is a duplicate here: https://svn.boost.org/trac/boost/ticket/8973

hongli@… — Sun, 27 Oct 2013 18:36:02 GMT

Modifying boost/atomic/atomic.hpp as follows also solves the compilation problem:

-    || (defined(_XOPEN_UNIX) && (_XOPEN_UNIX+0 > 0) && !defined(__UCLIBC__)) \
+    || (defined(_XOPEN_UNIX) && (_XOPEN_UNIX+0 > 0) && !defined(__UCLIBC__) && !defined(__GLIBC__)) \

timblechmann — Sun, 27 Oct 2013 18:40:33 GMT

as mentioned in the other bug, can you try boost-trunk?

hongli@… — Sun, 27 Oct 2013 18:46:10 GMT

Yes boost-trunk compiles without problems.