Boost C++ Libraries: Ticket #8027: thread library fails to compile with Visual Studio 2003

owner, status changed

viboes — Tue, 12 Feb 2013 06:37:34 GMT

owner changed from Anthony Williams to viboes
status new → assigned

It seems that the compiler doesn't like

        template <class Rp, class Fp>
        friend BOOST_THREAD_FUTURE<Rp>
        detail::make_future_async_object(BOOST_THREAD_FWD_REF(Fp) f);
        template <class Rp, class Fp>
        friend BOOST_THREAD_FUTURE<Rp>
        detail::make_future_deferred_object(BOOST_THREAD_FWD_REF(Fp) f);

I have no way to check it. Please could you try commenting these lines and make public all the needed members?

Tue, 12 Feb 2013 06:53:19 GMT

If I comment out those lines, it successfully compiles!

Thanks

status changed; resolution set; milestone deleted

viboes — Tue, 12 Feb 2013 07:06:13 GMT

status assigned → closed
resolution → wontfix
milestone To Be Determined

Gald to see that this work for you. I will no make any change on the repository.

Wed, 06 Mar 2013 12:15:43 GMT

Replying to viboes:

Gald to see that this work for you. I will no make any change on the repository.

Hello,

I'm not sure whether I understood the meaning of this posting, regarding changes for the next release of boost. I really would appreciate the code being fixed for MSVC .NET 2003 in the next release of boost. Thanks to this ticket here we were able to reproduce the fix and to build boost thread on MSVC2003 at all. I.e. we have a conditional compilation flag around the lines L1390-L1396 above.

before L1390: (file boost/thread/future.hpp, release 1_53_0)

#if (!defined _MSC_VER || _MSC_VER >= 1400) // _MSC_VER == 1400 on MSVC 2005

after L1396:

#endif // #if (!defined _MSC_VER || _MSC_VER >= 1400)

This should activate the code for compilers that don't define _MSC_VER (i.e. non-Microsoft compilers) and also for Microsoft compilers from MSVC 2005 and newer; MSVC 2003 then disregards the lines it does not understand syntactically. With this modification, thread.lib was built successfully on MSVC 2003, 2008, 2010, 2012, MinGW GCC 4.7.2 on x86 and x64. I didn't test MSVC 2005 (don't have it any longer) and I was too lazy to test with a MinGW GCC 4.8.0 preview. I don't know if there are any side effects if that functions are not declared as friends (MSVC 2003 only), but until now there didn't occur any problems in our application.

Best regards

Manfred

status changed; resolution deleted

viboes — Wed, 20 Mar 2013 22:26:19 GMT

status closed → reopened
resolution wontfix

viboes — Wed, 20 Mar 2013 22:31:04 GMT

I will fix it soon.

milestone set

viboes — Sat, 23 Mar 2013 01:28:29 GMT

milestone → Boost 1.54.0

Committed in trunk [83521].

status changed; resolution set

viboes — Sun, 31 Mar 2013 10:56:54 GMT

status reopened → closed
resolution → fixed

(In [83660]) Thread: merge from trunk 1.54. Fix #8027,#8323,#8337.