Boost C++ Libraries: Ticket #8032: Warning fixes in circular_buffer

attachment set

Tue, 12 Feb 2013 09:22:33 GMT

attachment → circular_buffer.diff

owner, status changed

Marshall Clow — Tue, 21 May 2013 18:26:34 GMT

owner changed from Jan Gaspar to Marshall Clow
status new → assigned

Marshall Clow — Tue, 21 May 2013 19:14:25 GMT

Applied patch in [84405]

status changed; resolution set

Marshall Clow — Thu, 23 May 2013 18:45:35 GMT

status assigned → closed
resolution → fixed

(In [84450]) Apply patch to release branch; Fixes #8032

pbf@… — Tue, 12 Nov 2013 21:25:28 GMT

When building against boost 1.55 using VisualStudio 2010 with warning level 4, I now see:

1>C:\src\svn\OTI\ThirdParty\boost_1_55_0_OT1\include\boost/circular_buffer/base.hpp(199): warning C4172: returning address of local variable or temporary

Likewise, building using gcc 4.4.7 on RedHat produces the following warning:

/media/sf_C_DRIVE/src/svn/OTI/ThirdParty/boost_1_55_0_OT1/include/boost/circular_buffer/base.hpp:2157: error: suggest parentheses around ‘&&’ within ‘

’

The MSVC issue seems to be a regression introduced by the adoption of move semantics (ticket #7888), so I'll make the same comment there. I'm guessing it's the same case for the gcc warning, although the warning itself doesn't make much sense to me, given the line in question is:

replace(p, this_type::move_if_noexcept(*next));

pbf@… — Tue, 12 Nov 2013 22:27:32 GMT

Just to follow up, Antony has kindly said he'll fix the warnings as part of #7888, so hopefully circular_buffer will be warning free once again.

michael.broida@… — Thu, 22 May 2014 22:52:29 GMT

We have hit the same warnings in 1.55.0 with VS2010 and all warnings treated as errors. This issue shows "fixed", but where/when was it fixed? #7888 shows "reopened", but that was six months ago and no more info.

Thu, 16 Oct 2014 14:40:45 GMT

Using Boost 1.56.0 warning C4172 is still reported by VS2010.