Boost C++ Libraries: Ticket #8212: Boost thread compilation error on Solaris 10

owner, status changed

viboes — Sat, 02 Mar 2013 22:57:02 GMT

owner changed from Anthony Williams to viboes
status new → assigned

viboes — Sun, 03 Mar 2013 09:03:43 GMT

Does the following patch help?

 svn diff ../../../boost/thread
Index: ../../../boost/thread/future.hpp
===================================================================
--- ../../../boost/thread/future.hpp	(revision 83254)
+++ ../../../boost/thread/future.hpp	(working copy)
@@ -3234,7 +3234,7 @@
     typedef typename decay<T>::type future_type;
     promise<future_type> p;
     p.set_value(boost::forward<T>(value));
-    return p.get_future();
+    return BOOST_THREAD_MAKE_RV_REF(p.get_future());
   }
@@ -3254,14 +3254,14 @@
     typedef typename decay<T>::type future_type;
     promise<future_type> p;
     p.set_value(boost::forward<T>(value));
-    return p.get_future().share();
+    return BOOST_THREAD_MAKE_RV_REF(p.get_future().share());
   }
   inline shared_future<void> make_shared_future()
   {
     promise<void> p;
-    return p.get_future().share();
+    return BOOST_THREAD_MAKE_RV_REF(p.get_future().share());
   }

milestone changed

viboes — Sat, 09 Mar 2013 16:01:07 GMT

milestone To Be Determined → Boost 1.54.0

Committed revision [83370].

nicolas.jouvray@… — Wed, 13 Mar 2013 10:21:08 GMT

Sorry but I was not able to test the patch before. I still have an error.

"./boost/thread/future.hpp", line 3244: Error: boost::unique_future<void>::unique_future(boost::unique_future<void>&) is not accessible from boost::make_future().
1 Error(s) detected.
    "CC" -xO4 -mt -erroff=%none -m32 -KPIC -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -DNDEBUG -I"." -c -o "bin.v2/libs/thread/build/sun/release/address-model-32/threading-multi/pthread/thread.o" "libs/thread/src/pthread/thread.cpp"

The line 3244 in this revision is the following one ;

  inline BOOST_THREAD_FUTURE<void> make_future()
  {
    promise<void> p;
    return p.get_future(); // <-- This one
  }

attachment set

viboes — Wed, 13 Mar 2013 22:03:30 GMT

attachment → 8212.patch

Could you try this additional patch?

nicolas.jouvray@… — Thu, 14 Mar 2013 09:54:55 GMT

This patch is OK ! Thanks

viboes — Sat, 16 Mar 2013 08:36:20 GMT

Committed in trunk [83425][83456].

Note that [83456] rollbacks one of the changes in [83425] as it introduce regressions in other compilers. Please could you try it?

nicolas.jouvray@… — Mon, 18 Mar 2013 07:02:23 GMT

It is OK.

status changed; resolution set

viboes — Sat, 23 Mar 2013 02:16:44 GMT

status assigned → closed
resolution → fixed

Committed revision [83525].