Boost C++ Libraries: Ticket #8245: strerror is not thread-safe on all platforms

component changed; owner set

Andrey Semashev — Tue, 05 Mar 2013 09:14:48 GMT

owner set to No-Maintainer
component None → random

owner changed

Andrey Semashev — Tue, 05 Mar 2013 09:17:27 GMT

owner changed from No-Maintainer to Steven Watanabe

status changed; resolution set

Steven Watanabe — Thu, 13 Mar 2014 22:17:51 GMT

status new → closed
resolution → fixed

Fixed in http://github.com/boostorg/random/commit/dac48f62a8481560c2e8005bb6edcbfd409b3004.

status changed; resolution deleted

Andrey Semashev — Fri, 14 Mar 2014 06:28:32 GMT

status closed → reopened
resolution fixed

The use of errno is still not fixed. It should be read once immediately at the beginning of error(const char * msg). Otherwise it may be clobbered by construction of other arguments to system_error constructor.

Andrey Semashev — Fri, 14 Mar 2014 06:38:53 GMT

Pull request: https://github.com/boostorg/random/pull/2

status changed; resolution set

Steven Watanabe — Fri, 14 Mar 2014 14:30:46 GMT

status reopened → closed
resolution → fixed

Andrey Semashev — Tue, 08 Apr 2014 09:52:45 GMT

Steven, you closed the ticket but did not merge the pull request. Was this intentional? Are you rejecting the proposed fix?

Steven Watanabe — Tue, 08 Apr 2014 14:23:33 GMT

Don't expect me to merge pull requests in general. Especially for things that are this simple, it's easier for me to type it in myself than to figure out the git commands I would need. I also generally make some changes when applying patches. In this case, the fix I applied is not quite the same as your pull request because I used the name error_code instead of err, to be consistent with the name in the Windows implementation.