Boost C++ Libraries: Ticket #8262: numeric::average gives incorrect result

attachment set

james.hirschorn@… — Thu, 07 Mar 2013 23:30:38 GMT

patch giving correct average

james.hirschorn@… — Thu, 07 Mar 2013 23:31:22 GMT

patch correcting numeric::average

james.hirschorn@… — Thu, 07 Mar 2013 23:33:07 GMT

The first attachment was by accident. functional.hpp is the modified source.

Eric Niebler — Sat, 08 Jun 2013 21:03:30 GMT

Looks right to me.

Eric Niebler — Sat, 08 Jun 2013 21:04:46 GMT

Oops, I see what you mean. Sory 'bout that. I'll have a look.

Eric Niebler — Tue, 23 Jul 2013 06:28:56 GMT

(In [85124]) rename average to fdiv, refs #8262

Eric Niebler — Tue, 23 Jul 2013 06:31:28 GMT

Fixed on trunk. I'll merge to release after tests have cycled. The function isn't incorrect per se; it's just very, very badly named.

Eric Niebler — Thu, 22 Aug 2013 19:39:57 GMT

(In [85424]) merge [85122],[85123],[85124] from trunk to release; fixes #7915, fixes #8850, fixes #8262

timpie.w@… — Mon, 12 May 2014 12:01:48 GMT

The fix seems incorrect.

typedef typename functional::divides<Left, Right>::result_type result_type;

looks incorrect and I think it should be

typedef typename functional::divides<

typename functional::plus<Left, Right>::result_type, int>::result_type result_type;