Boost C++ Libraries: Ticket #8267: lexical_cast uses stream buffers incorrectly

status changed

Antony Polukhin — Sat, 16 Mar 2013 09:42:24 GMT

status new → assigned

parser_buf looks good, I'd like to use it, but I do not want to add dependency to Boost.Regex. Can you move it to boost/utility or boost/detail? I think this class can be used by lots of people (I've saw some projects that make something similar to provide stack allocated buffer)

anonymous — Sat, 16 Mar 2013 17:22:57 GMT

I'm happy to move to boost/detail, but looking around I see the iostreams lib has the same functionality, just tried this:

#include <boost/iostreams/stream_buffer.hpp>
#include <boost/iostreams/device/array.hpp>
int main()
{
   namespace io = boost::iostreams;
   const char* buf = "12345.6789";
   io::stream_buffer<io::array_source> sb(buf, buf + std::strlen(buf));
   std::istream is(&sb);
   double d;
   is >> d;
   std::cout << d << std::endl;
   assert(is.rdbuf()->in_avail() == 0);
   return 0;
}

Is that a better bet?

Antony Polukhin — Sun, 24 Mar 2013 15:26:47 GMT

(In [83543]) Reimplement STL string buffer unlocker (refs #8267 and refs #7704)

milestone changed

Antony Polukhin — Sun, 24 Mar 2013 15:44:24 GMT

milestone To Be Determined → Boost 1.54.0

boost/regex/v4/cpp_regex_traits.hpp version does not fit 100%, copy-pasted it, slightly modified and committed it to lexical_cast.hpp.

Iostreams library is huge, also did not fit 100%.

John Maddock — Mon, 25 Mar 2013 19:15:27 GMT

The change is causing quite a few breakages in Multiprecision, quite a few lexical_cast tests are failing too: http://www.boost.org/development/tests/trunk/developer/conversion.html

Antony Polukhin — Tue, 26 Mar 2013 07:57:26 GMT

Working on that...

Antony Polukhin — Wed, 27 Mar 2013 17:00:49 GMT

(In [83601]) Update code that uses string buffers (refs #8267). Treat cast to pointer as compile time error (refs #8334). Update documentation

Antony Polukhin — Thu, 28 Mar 2013 16:03:16 GMT

Now libc++ fails. Fixing again...

Antony Polukhin — Sat, 30 Mar 2013 07:20:26 GMT

(In [83642]) Fix streams and buffers usage (refs #8267 and refs #7704). Now conversions the use STL streams shall work faster

status changed; resolution set

Antony Polukhin — Mon, 01 Apr 2013 20:40:46 GMT

status assigned → closed
resolution → fixed

(In [83689]) Merge from trunk:

Fix stream related issues with libc++ and clang (fixes #7704, fixes #8267)
Change runtime assert to compile time when converting to pointer (fixes #8267)