Boost C++ Libraries: Ticket #8278: BOOST_ASSERT_MSG prerocessed out if NDEBUG is defined regardless of BOOST_ENABLE_ASSERT_HANDLER

owner changed

Peter Dimov — Tue, 12 Mar 2013 08:06:09 GMT

owner changed from Peter Dimov to Beman Dawes

I think that Beman added the _MSG variants. I agree that ASSERT_MSG should follow ASSERT.

status changed; resolution set

viboes — Thu, 14 Mar 2013 17:50:02 GMT

status new → closed
resolution → duplicate

duplicated of #7028

status changed; resolution deleted

Eric Niebler — Thu, 14 Mar 2013 20:29:47 GMT

status closed → reopened
resolution duplicate

I don't believe this issue is a dupe of #7028. That issue (which I disagree with) suggests that all the assert macros be processed out when NDEBUG is defined, even when BOOST_ENABLE_ASSERT_HANDLER is defined. This issue is specifically about making BOOST_ASSERT_MSG consistent with the other macros, which are currently left in always when BOOST_ENABLE_ASSERT_HANDLER is defined.

viboes — Thu, 14 Mar 2013 21:29:51 GMT

#7028 patch makes the 3 macros uniform. Could you provide a patch that clarifies what do you expect?

viboes — Thu, 14 Mar 2013 21:56:25 GMT

Replying to viboes:

#7028 patch makes the 3 macros uniform. Could you provide a patch that clarifies what do you expect?

Oh, I think I understand the issue now. See #7028.

attachment set

Eric Niebler — Thu, 14 Mar 2013 22:00:03 GMT

attachment → assert.patch

Eric Niebler — Thu, 14 Mar 2013 22:01:10 GMT

I've attached a patch that addressed the problem the way I think it should be addressed, and the way that is least surprising for existing users of BOOST_ASSERT. It should be applied to trunk as it is as of [83430].