Boost C++ Libraries: Ticket #8283: list_new/list_push_back missing object_copy

attachment set

Tue, 12 Mar 2013 08:40:07 GMT

attachment → fix-lame-object-copying.patch

Steven Watanabe — Tue, 12 Mar 2013 16:19:15 GMT

These functions are not supposed to make copies. They take ownership of their arguments. Your patch will result in a memory leak with BJAM_NO_MEM_CACHE. The correct fix is to track down the caller that isn't making a copy.

Wed, 13 Mar 2013 10:00:29 GMT

Ah, I know. I will track down true problems and make patch again.

attachment set

Thu, 14 Mar 2013 08:53:55 GMT

attachment → fix-missing-object_copy.patch

Thu, 14 Mar 2013 08:56:20 GMT

How is above one?

Steven Watanabe — Fri, 29 Mar 2013 16:39:28 GMT

(In [83630]) Add missing object_copy. Refs #8283.

Steven Watanabe — Fri, 29 Mar 2013 16:49:09 GMT

I've committed the path.c fix. I'm not sure what the reason for the pathnt.c change is, though. AFAICT, path should be either overwritten on line 232 or copied on line 249.

anonymous — Mon, 01 Apr 2013 15:01:40 GMT

Indeed, I'd had to do scrutiny. Sorry for the confusion.

status changed; resolution set

Steven Watanabe — Tue, 11 Mar 2014 21:02:53 GMT

status new → closed
resolution → fixed