Boost C++ Libraries: Ticket #8328: chrono crashes visual studio 2012 regression tests

attachment set

Sat, 23 Mar 2013 15:33:04 GMT

attachment → io_ex1_d-callstack.txt

io_ex1_d callstack

attachment set

Sat, 23 Mar 2013 15:33:23 GMT

attachment → io_ex1_h-callstack.txt

io)ex1_h callstack

attachment set

Sat, 23 Mar 2013 15:33:50 GMT

attachment → v1_io_ex1_h-callstack.txt

v1_io_ex1_h callstack

Sat, 23 Mar 2013 15:34:54 GMT

I also have the minidump files (about 11MB each)

viboes — Sat, 23 Mar 2013 16:26:28 GMT

Replying to Thomas Kent <teeks99@…>:

I also have the minidump files (about 11MB each)

http://boost.teeks99.com/misc/chrono_crash/io_ex1_d.dmp
http://boost.teeks99.com/misc/chrono_crash/io_ex1_h.dmp
http://boost.teeks99.com/misc/chrono_crash/v1_io_ex1_h.dmp

Sorry I don't use visual studio and I don't know how to make use of these files. Thanks anyway.

viboes — Sat, 23 Mar 2013 16:44:42 GMT

From the regression test I see that there is error for MSVC 11, but it works for MSVC 10. Unfortunately I have not installed MSVC 11.

Anyway as the trace show there is an error on the test Jamfile as even if the test is named v1_ it is using version 2. See the patch below.

Index: Jamfile.v2
===================================================================
--- Jamfile.v2	(revision 83520)
+++ Jamfile.v2	(working copy)
@@ -110,7 +110,7 @@
         :   <define>BOOST_CHRONO_HEADER_ONLY
             <define>BOOST_ERROR_CODE_HEADER_ONLY
            #<define>BOOST_CHRONO_DONT_PROVIDE_HYBRID_ERROR_HANDLING
-            <define>BOOST_CHRONO_VERSION=2
+           #<define>BOOST_CHRONO_VERSION=1
         :   v1_$(sources[1]:B)_h ]
     ;
 }

Could you try this test forcing the version 2

Index: boost/chrono/config.hpp
===================================================================
--- boost/chrono/config.hpp	(revision 83520)
+++ boost/chrono/config.hpp	(working copy)
@@ -14,7 +14,7 @@
 #include <boost/config.hpp>
 #if !defined BOOST_CHRONO_VERSION
-#define BOOST_CHRONO_VERSION 1
+#define BOOST_CHRONO_VERSION 2
 #else
 #if BOOST_CHRONO_VERSION!=1  && BOOST_CHRONO_VERSION!=2
 #error "BOOST_CHRONO_VERSION must be 1 or 2"

to see if there is something that makes io V2 incompatible with V1.

status changed

viboes — Sat, 23 Mar 2013 16:45:57 GMT

status new → assigned

Sun, 24 Mar 2013 19:02:29 GMT

Those changes didn't seem to affect anything....assuming my bjam skills are correct. After making the changes (in boost-trunk\libs\chrono\test) I ran "b2 toolset=msvc-11.0 -a". Is that what I should have done?

viboes — Sun, 24 Mar 2013 20:15:28 GMT

Replying to Thomas Kent <teeks99@…>:

Those changes didn't seem to affect anything....assuming my bjam skills are correct. After making the changes (in boost-trunk\libs\chrono\test) I ran "b2 toolset=msvc-11.0 -a". Is that what I should have done?

Have you applied the change to boost/chrono/config.hpp?

Sun, 24 Mar 2013 22:55:24 GMT

Yes, before running the above bjam command I applied the change to config.hpp and to Jamfile.v2.

viboes — Wed, 10 Apr 2013 17:05:46 GMT

This seems a regression with the I/O library of msvc-11.0. Do you know if there are some bugs associated to msvc-11.0 that could be related?

For the time being I'm unable to debug it. I will appreciate if you could you try to do a deeper analysis and post it here.

severity changed

viboes — Sun, 09 Jun 2013 19:52:03 GMT

severity Regression → Problem

This is not a regression as Boost.Chrono can not anticipate the behavior of new compilers.

summary changed

viboes — Fri, 14 Jun 2013 05:33:55 GMT

summary chrono crashes visual studio regression tests → chrono crashes visual studio 2012 regression tests

viboes — Tue, 10 Sep 2013 20:09:30 GMT

Have you reported the issue to Microsoft?

status changed; resolution set

viboes — Sun, 20 Oct 2013 18:36:15 GMT

status assigned → closed
resolution → wontfix

The test are passing with msvn 9, 10 and 12. I will not try to fix it.

Mon, 21 Oct 2013 14:02:40 GMT

If we're not going to fix this for msvc-11.0, can we just BOOST_FAIL() the tests for that compiler version, so that it doesn't keep crashing the whole regression test?

viboes — Mon, 21 Oct 2013 17:06:50 GMT

Ok. I will do.

viboes — Mon, 21 Oct 2013 22:00:01 GMT

Does this patch avoids the crach

svn diff  libs/chrono/example/io_ex1.cpp
Index: libs/chrono/example/io_ex1.cpp
===================================================================
--- libs/chrono/example/io_ex1.cpp	(revision 86380)
+++ libs/chrono/example/io_ex1.cpp	(working copy)
@@ -53,10 +53,13 @@
          <<  ClockTick(3) + nanoseconds(10) << '\n';
     cout << "\nsystem_clock::now() = " << system_clock::now() << '\n';
+#if defined _MSC_VER && _MSC_VER == 1700
+#else
 #if BOOST_CHRONO_VERSION==2
     cout << "\nsystem_clock::now() = " << time_fmt(chrono::timezone::local) << system_clock::now() << '\n';
     cout << "\nsystem_clock::now() = " << time_fmt(chrono::timezone::local,"%Y/%m/%d") << system_clock::now() << '\n';
 #endif
+#endif
 #ifdef BOOST_CHRONO_HAS_CLOCK_STEADY
     cout << "steady_clock::now() = " << steady_clock::now() << '\n';

Committed revision [86384].