Boost C++ Libraries: Ticket #8333: [math] PGI 11.3 problems (sph_bessel.cpp, sph_bessel.cpp)

John Maddock — Mon, 25 Mar 2013 17:09:18 GMT

No it's not a known issue, is there no std::abs(long double) overload on that platform?

I could change it to use std::fabs if that helps?

Tue, 26 Mar 2013 08:58:11 GMT

Hi,

I warn you, I've not done any C++ before, but I'm not sure that's the problem - the following test compiles and prints out 3.14:

#include <cmath>
#include <iostream>
int main()
{
   long double value = -3.14;
   cout << "Absolute: " << std::abs(value) << endl;
}

$ pgCC -o test2 test2.cpp
$ ./test2
Absolute: 3.14

Steven Watanabe — Tue, 26 Mar 2013 13:32:18 GMT

What happens if you add #include <cstdlib> to your test case?

John Maddock — Tue, 26 Mar 2013 13:38:45 GMT

What happens if you add #include <cstdlib> to your test case?

That was going to be my next question as well, add

#include <cstdlib>

To the very top of libs/math/src/tr1/sph_bessel.cpp

Tue, 26 Mar 2013 14:58:47 GMT

Thank you both for the suggestions, but I'm afraid there's no change:-

My test case still works and the boost build still fails (with the same message - except it's now complaining about line 17 of sph_bessel.cpp instead of 16)

Mark

alan.r.wild@… — Wed, 03 Apr 2013 03:06:50 GMT

I'm also seeing this error on PGI 12.2 and PGI 12.5 on SuSE 11 (CLE4, specifically). Same system compiling with GCC (4.6.1, 4.6.2, 4.7.0, & 4.7.1), Intel 11.1 or Cray's compiler (8.0 and 8.1) aren't showing this error.

anonymous — Wed, 03 Apr 2013 08:22:40 GMT

Are you able to do a quick grep and find out which header defines std::abs(long double) on that platform as from the comments above neither <cmath> nor <cstdlib> appear to be defining it?

Thanks, John.

Wed, 03 Apr 2013 11:55:50 GMT

For PGI 11.3, it seems to be in:

${PGI_HOME}/include/CC/stl/_cmath.h

Which is included by the following headers:

${PGI_HOME}/include/CC/cmath
${PGI_HOME}/include/CC/stl/_valarray.h
${PGI_HOME}/include/CC/stl/_complex.h

So it "should" be included.

Sticking the following definition:

long double abs (long double __x) { return __x; }

At the very top of sph_bessel.cpp results in the following compile error:

"/apps/compilers/pgi/11.3/1/default/linux86-64/11.3/include/CC/stl/_cmath.h", line 208: error:
          function "std::abs(long double)" conflicts with using-declaration of
          function "abs(long double)"
  inline long double abs (long double __x)                  { return _STLP_DO_ABS(long double)((double)__x); }
                     ^
"./boost/math/special_functions/fpclassify.hpp", line 85: error:
          using-declaration of function "abs(long double)" conflicts with
          function "std::abs(long double)" (declared at line 208 of
          "/apps/compilers/pgi/11.3/1/default/linux86-64/11.3/include/CC/stl/_c
          math.h")
    namespace std{ using ::abs; using ::fabs; }
                           ^
2 errors detected in the compilation of "libs/math/src/tr1/sph_bessel.cpp".

So it would appear that it is being included.

Alternatively, if I alter sph_bessel.cpp to read:

//  Copyright John Maddock 2008.
//  Use, modification and distribution are subject to the
//  Boost Software License, Version 1.0.  (See accompanying file
//  LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
//
#  include <pch.hpp>
#ifndef BOOST_MATH_TR1_SOURCE
#  define BOOST_MATH_TR1_SOURCE
#endif
#include <boost/math/tr1.hpp>
#include <boost/math/special_functions/bessel.hpp>
#include "c_policy.hpp"
extern "C" double BOOST_MATH_TR1_DECL boost_sph_bessel BOOST_PREVENT_MACRO_SUBSTITUTION(unsigned n, double x) BOOST_MATH_C99_THROW_SPEC
{
   long double val = 3.14;
   std::abs(val);
   return c_policies::sph_bessel BOOST_PREVENT_MACRO_SUBSTITUTION(n, x);
}

I get the 3 compile errors originally reported, but no new ones. sph_bessel.cpp clearly knows about the long double abs definition.

Presumably the problem is deep in the include files?

Thanks,

Mark

anonymous — Wed, 03 Apr 2013 14:16:30 GMT

OK, next try: can you replace in boost/math/special_functions/sinc.hpp, from line 64

#if defined(BOOST_NO_STDC_NAMESPACE) && !defined(__SUNPRO_CC)
            using    ::abs;
            using    ::sin;
            using    ::sqrt;
#else    /* BOOST_NO_STDC_NAMESPACE */
            using    ::std::abs;
            using    ::std::sin;
            using    ::std::sqrt;
#endif    /* BOOST_NO_STDC_NAMESPACE */

with simply

BOOST_MATH_STD_USING

And see if that kills some of the errors?

Wed, 03 Apr 2013 14:42:45 GMT

Nice one - library "math" now builds with no compiler errors at all :)

Thanks,

Mark

status changed; resolution set

John Maddock — Wed, 03 Apr 2013 18:06:28 GMT

status new → closed
resolution → fixed

Fixed in Trunk.

John Maddock — Sat, 28 Sep 2013 16:19:56 GMT

(In [85987]) Merge accumulated patches from Trunk. Refs #8384, Refs #8855, refs #9107, refs #9109, refs #8333, refs #8621, refs #8732, refs #8733, refs #8837, refs #8940, refs #9042, refs #9087, refs #9104, refs #9126.