severity changed

chris_kohlhoff — Fri, 24 May 2013 03:44:07 GMT

severity Problem → Cosmetic

These descriptor_state objects are recycled via an object_pool. The next_ and prev_ members are set by the pool. The other members are set after the object has been obtained from the pool. It would seem that all code paths do set the members correctly and so the warning is purely a cosmetic issue. I'll look at fixing in the future provided there are no performance impacts.

Fri, 24 May 2013 12:20:52 GMT

ok. It seems a little odd that we rely on the code that constructs these objects to properly initialize them, as that is usually the responsibility of the constructor of the object.

I have another question.

In epoll_reactor.ipp:

int epoll_reactor::register_descriptor(socket_type descriptor,
    epoll_reactor::per_descriptor_data& descriptor_data)
{
  descriptor_data = allocate_descriptor_state();
  {
    mutex::scoped_lock descriptor_lock(descriptor_data->mutex_);
    descriptor_data->reactor_ = this;
    descriptor_data->descriptor_ = descriptor;
    descriptor_data->shutdown_ = false;
  }
  epoll_event ev = { 0, { 0 } };
  ev.events = EPOLLIN | EPOLLERR | EPOLLHUP | EPOLLPRI | EPOLLET;
  descriptor_data->registered_events_ = ev.events;
  ev.data.ptr = descriptor_data;
  int result = epoll_ctl(epoll_fd_, EPOLL_CTL_ADD, descriptor, &ev);
  if (result != 0)
    return errno;
  return 0;
}

Why are all the other members set inside the scope of the lock, but registered_events_ is modified outside the scope of the lock?

Boost C++ Libraries: Ticket #8348: asio::detail::epoll_reactor::descriptor_state c'tor doesn't initialize all POD members

severity changed