Boost C++ Libraries: Ticket #8391: boost::local_time::tz_database::load_from_file uses unchecked iterator

attachment set

frank.oosterhuis@… — Thu, 04 Apr 2013 12:25:27 GMT

attachment → main.cpp

test program

attachment set

frank.oosterhuis@… — Thu, 04 Apr 2013 12:25:48 GMT

attachment → date_time_zonespec.csv

faulty csv

severity, milestone changed

frank.oosterhuis@… — Thu, 04 Apr 2013 12:26:22 GMT

severity Problem → Showstopper
milestone To Be Determined → Boost 1.54.0

attachment set

frank.oosterhuis@… — Thu, 04 Apr 2013 12:39:07 GMT

attachment → b8391.patch

patch

cc set

frank@… — Fri, 05 Apr 2013 11:10:17 GMT

cc frank@… added

owner changed

Marshall Clow — Tue, 04 Jun 2013 20:11:26 GMT

owner changed from az_sw_dude to Marshall Clow

When I run this test, I get execption: bad lexical cast: source type value could not be interpreted as target, and applying the supplied patch does not change this.

I agree there's a problem here, and I think that the code you're patching can be made more robust, but the bug that your code is triggering is (I think) not the one that your patch fixes.

Then again, I'm not running in gcc debug mode.

frank.oosterhuis@… — Wed, 05 Jun 2013 09:49:18 GMT

I am not able to get the same execption (bad lexical cast). Always crashes with "Assertion `valid_' failed."

Tested with 1.53, 1.54_beta0 and trunk (r84644).

Compiled using: g++ -I ../boost_1_53_0 ./main.cpp -o ./bin/bug_boost_153 Version: gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1)

Marshall Clow — Wed, 05 Jun 2013 20:04:13 GMT

(In [84645]) More error checking on tz files; Refs #8391

frank.oosterhuis@… — Thu, 13 Jun 2013 09:14:58 GMT

Fix confirmed.

boost::local_time::bad_field_count is now thrown.

status changed; resolution set

Marshall Clow — Thu, 13 Jun 2013 14:00:49 GMT

status new → closed
resolution → fixed

(In [84755]) Apply patch to release branch; Fixes #8391