Boost C++ Libraries: Ticket #8403: VC++ 2012 compiler warning C4127: conditional expression is constant

Fri, 05 Apr 2013 15:06:06 GMT

Sorry, I mixed the code with the message. Unfortunately I cannot edit the original post, so here are the messages with the correct line breaks:

\boost_1_52_0\boost\geometry\algorithms\convert.hpp(96): error C4127: conditional expression is constant
if (Close) ...

\boost_1_52_0\boost\geometry\algorithms\detail\overlay\get_turns.hpp(263): error C4127: conditional expression is constant
if (InterruptPolicy::enabled) ...

\boost_1_52_0\boost\geometry\algorithms\num_points.hpp(51): error C4127: conditional expression is constant
if (s == open) ...

type, severity changed

Barend Gehrels — Fri, 05 Apr 2013 20:58:09 GMT

type Bugs → Support Requests
severity Problem → Cosmetic

This is not a bug. This requires considerable rewriting and adding speciliazations. Postponed.

status changed; resolution set

Barend Gehrels — Sat, 06 Apr 2013 22:49:07 GMT

status new → closed
resolution → fixed

Barend Gehrels — Sun, 07 Apr 2013 11:20:47 GMT

After doubting about this one, and looking at other Boost.Libraries, it is indeed probably the best to use #pragma's here. Many libraries do the same for the same problem.

Alternatives were rewriting (too much), or declaring local non-const variables to avoid this warning (I considered this as too much workaround for this message only, and this has a (though small) performance penalty)

So pragmas are added yesterday.

Thu, 16 Oct 2014 10:25:37 GMT

This is related to Ticket #10666.