Boost C++ Libraries: Ticket #8458: -DBOOST_THREAD_DONT_USE_CHRONO in thread.obj.rsp but not explicitly set

attachment set

anonymous — Thu, 18 Apr 2013 13:48:00 GMT

attachment → thread_use_chrono.patch

viboes — Thu, 18 Apr 2013 21:47:15 GMT

Are you sure you are using 1.53? Where do you see that

boost::thread::try_join_until(const chrono::time_point<chrono::system_clock, chrono::nanoseconds>&);

is declared with dllimport?

owner, status changed

viboes — Thu, 18 Apr 2013 21:47:26 GMT

owner changed from Anthony Williams to viboes
status new → assigned

anonymous — Thu, 18 Apr 2013 21:52:02 GMT

Replying to viboes:

Are you sure you are using 1.53? Where do you see that
boost::thread::try_join_until(const chrono::time_point<chrono::system_clock, chrono::nanoseconds>&);
is declared with dllimport?

It's implicitly dllexport/dllimport because the whole class boost::thread is declared so via BOOST_THREAD_DECL.

viboes — Thu, 18 Apr 2013 22:07:19 GMT

Replying to anonymous:

Replying to viboes:
Are you sure you are using 1.53? Where do you see that
boost::thread::try_join_until(const chrono::time_point<chrono::system_clock, chrono::nanoseconds>&);
is declared with dllimport?
It's implicitly dllexport/dllimport because the whole class boost::thread is declared so via BOOST_THREAD_DECL.

Thanks for clarification. I don't know how to use msvc import/export correctly. Could I remove the BOOST_THREAD_DECL on the class thread declaration and add it to the functions that are really exported?

anonymous — Wed, 24 Apr 2013 13:56:15 GMT

Replying to viboes:

Replying to anonymous:
Replying to viboes:
Are you sure you are using 1.53? Where do you see that
boost::thread::try_join_until(const chrono::time_point<chrono::system_clock, chrono::nanoseconds>&);
is declared with dllimport?
It's implicitly dllexport/dllimport because the whole class boost::thread is declared so via BOOST_THREAD_DECL.
Thanks for clarification. I don't know how to use msvc import/export correctly. Could I remove the BOOST_THREAD_DECL on the class thread declaration and add it to the functions that are really exported?

Yes I think that would work fine (untested). Thanks for taking a look at this.

attachment set

viboes — Wed, 24 Apr 2013 16:37:26 GMT

attachment → 8458.patch

Please, could you check the attached patch?

anonymous — Thu, 25 Apr 2013 09:16:39 GMT

Would you mind attaching a unified diff?

attachment set

viboes — Sat, 27 Apr 2013 05:32:36 GMT

attachment → 8458.2.patch

Replaced erroneus patch

viboes — Sat, 27 Apr 2013 05:34:03 GMT

Replying to anonymous:

Would you mind attaching a unified diff?

I did a svn st instead of a svn diff :( Please take a look at 8458.2.patch.

anonymous — Wed, 01 May 2013 09:56:53 GMT

Replying to viboes:

Replying to anonymous:

Would you mind attaching a unified diff?

I did a svn st instead of a svn diff :( Please take a look at 8458.2.patch.

This doesn't build for me. I think you changed boost::this_thread::get_id() but you meant to change boost::thread::get_id(). Btw I'm not convinced you need the additional decoration in the cpp file: isn't it implied by what's in the header file? It's possible I'm misunderstanding something.

milestone changed

viboes — Tue, 04 Jun 2013 06:25:07 GMT

milestone To Be Determined → Boost 1.54.0

After more deeper analysis I will not fix it, and Boost.Thread will need Boost.Chrono on Windows. I'll force it and documented the constraint.

anonymous — Tue, 04 Jun 2013 10:59:33 GMT

Replying to viboes:

After more deeper analysis I will not fix it, and Boost.Thread will need Boost.Chrono on Windows. I'll force it and documented the constraint.

OK great. I'll test any patch you post here.

viboes — Sat, 08 Jun 2013 13:41:53 GMT

Could you tell me if the following works for you?

svn diff  libs/thread/build/Jamfile.v2 boost/thread/detail/config.hpp
Index: libs/thread/build/Jamfile.v2
===================================================================
--- libs/thread/build/Jamfile.v2	(revision 84414)
+++ libs/thread/build/Jamfile.v2	(working copy)
@@ -263,8 +263,11 @@
                 result = <build>no ;
             }
         }
+        result += <define>BOOST_THREAD_DONT_USE_CHRONO ;
+    } else {
+        result += <define>BOOST_THREAD_USES_CHRONO ;
+        result += <library>/boost/chrono//boost_chrono ;
     }
-    result += <define>BOOST_THREAD_DONT_USE_CHRONO ;
     if <toolset>pgi in $(properties)  || <toolset>vacpp in $(properties)
     {
Index: boost/thread/detail/config.hpp
===================================================================
--- boost/thread/detail/config.hpp	(revision 84414)
+++ boost/thread/detail/config.hpp	(working copy)
@@ -318,6 +318,11 @@
 #define BOOST_THREAD_USES_DATETIME
 #endif
+#if defined(BOOST_THREAD_PLATFORM_WIN32) && defined BOOST_THREAD_DONT_USE_CHRONO
+#undef BOOST_THREAD_DONT_USE_CHRONO
+#define BOOST_THREAD_USES_CHRONO
+#endif
+
 // BOOST_THREAD_PROVIDES_DEPRECATED_FEATURES_SINCE_V3_0_0 defined by default up to Boost 1.55
 // BOOST_THREAD_DONT_PROVIDE_DEPRECATED_FEATURES_SINCE_V3_0_0 defined by default up to Boost 1.55
 #if defined BOOST_THREAD_PROVIDES_DEPRECATED_FEATURES_SINCE_V3_0_0

viboes — Sun, 09 Jun 2013 08:30:47 GMT

Committed in trunk [84709]

anonymous — Mon, 10 Jun 2013 17:36:24 GMT

Replying to viboes:

Could you tell me if the following works for you?

svn diff  libs/thread/build/Jamfile.v2 boost/thread/detail/config.hpp
Index: libs/thread/build/Jamfile.v2
===================================================================
--- libs/thread/build/Jamfile.v2	(revision 84414)
+++ libs/thread/build/Jamfile.v2	(working copy)
@@ -263,8 +263,11 @@
                 result = <build>no ;
             }
         }
+        result += <define>BOOST_THREAD_DONT_USE_CHRONO ;
+    } else {
+        result += <define>BOOST_THREAD_USES_CHRONO ;
+        result += <library>/boost/chrono//boost_chrono ;
     }
-    result += <define>BOOST_THREAD_DONT_USE_CHRONO ;
     if <toolset>pgi in $(properties)  || <toolset>vacpp in $(properties)
     {
Index: boost/thread/detail/config.hpp
===================================================================
--- boost/thread/detail/config.hpp	(revision 84414)
+++ boost/thread/detail/config.hpp	(working copy)
@@ -318,6 +318,11 @@
 #define BOOST_THREAD_USES_DATETIME
 #endif
+#if defined(BOOST_THREAD_PLATFORM_WIN32) && defined BOOST_THREAD_DONT_USE_CHRONO
+#undef BOOST_THREAD_DONT_USE_CHRONO
+#define BOOST_THREAD_USES_CHRONO
+#endif
+
 // BOOST_THREAD_PROVIDES_DEPRECATED_FEATURES_SINCE_V3_0_0 defined by default up to Boost 1.55
 // BOOST_THREAD_DONT_PROVIDE_DEPRECATED_FEATURES_SINCE_V3_0_0 defined by default up to Boost 1.55
 #if defined BOOST_THREAD_PROVIDES_DEPRECATED_FEATURES_SINCE_V3_0_0

Yes it does. Thanks!

status changed; resolution set

viboes — Wed, 12 Jun 2013 21:01:12 GMT

status assigned → closed
resolution → fixed

Committed revision [84750].

viboes — Sat, 15 Jun 2013 10:35:46 GMT

(In [84792]) Thread: fix #8458 and update doc.