Boost C++ Libraries: Ticket #8476: Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic. https://svn.boost.org/trac10/ticket/8476 <p> Patch that inserts BOOST_FALLTHROUGH to annotate fallthrough between switch cases. Ticket with discussion of BOOST_FALLTHROUGH: <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/8408" title="#8408: Patches: Boost is not compatible with Clang's -Wimplicit-fallthrough diagnostic (closed: fixed)">#8408</a> </p> en-us Boost C++ Libraries /htdocs/site/boost.png https://svn.boost.org/trac10/ticket/8476 Trac 1.4.3 Alexander Kornienko <alexfh@…> Mon, 22 Apr 2013 14:41:30 GMT attachment set https://svn.boost.org/trac10/ticket/8476 https://svn.boost.org/trac10/ticket/8476 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">regex.patch</span> </li> </ul> Ticket John Maddock Mon, 22 Apr 2013 17:29:52 GMT status changed; resolution set https://svn.boost.org/trac10/ticket/8476#comment:1 https://svn.boost.org/trac10/ticket/8476#comment:1 <ul> <li><strong>status</strong> <span class="trac-field-old">new</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> (In <a class="changeset" href="https://svn.boost.org/trac10/changeset/84015" title="Apply patch from #8476. Fixes #8476.">[84015]</a>) Apply patch from <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/8476" title="#8476: Patches: Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic. (closed: fixed)">#8476</a>. Fixes <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/8476" title="#8476: Patches: Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic. (closed: fixed)">#8476</a>. </p> Ticket Alexander Kornienko <alexfh@…> Tue, 23 Apr 2013 15:43:54 GMT attachment set https://svn.boost.org/trac10/ticket/8476 https://svn.boost.org/trac10/ticket/8476 <ul> <li><strong>attachment</strong> → <span class="trac-field-new">boost-regex-fallthrough.patch</span> </li> </ul> Ticket Alexander Kornienko <alexfh@…> Tue, 23 Apr 2013 15:56:46 GMT <link>https://svn.boost.org/trac10/ticket/8476#comment:2 </link> <guid isPermaLink="false">https://svn.boost.org/trac10/ticket/8476#comment:2</guid> <description> <p> Thanks for applying the patch. Two things though: </p> <ol><li>You've missed two times "break;" and one time "BOOST_FALLTHROUGH;". I've attached a diff from current HEAD to the version with the first patch. </li></ol><ol start="2"><li>I've also noticed, that you've left "fall through/fallthrough/..." comments, which are redundant now. You definitely know better what's more readable to you, but after the change these comments really don't add any value. </li></ol> </description> <category>Ticket</category> </item> <item> <author>Alexander Kornienko <alexfh@…></author> <pubDate>Tue, 23 Apr 2013 15:57:31 GMT</pubDate> <title>status changed; resolution deleted https://svn.boost.org/trac10/ticket/8476#comment:3 https://svn.boost.org/trac10/ticket/8476#comment:3 <ul> <li><strong>status</strong> <span class="trac-field-old">closed</span> → <span class="trac-field-new">reopened</span> </li> <li><strong>resolution</strong> <span class="trac-field-deleted">fixed</span> </li> </ul> Ticket John Maddock Fri, 26 Apr 2013 10:33:25 GMT status changed; resolution set https://svn.boost.org/trac10/ticket/8476#comment:4 https://svn.boost.org/trac10/ticket/8476#comment:4 <ul> <li><strong>status</strong> <span class="trac-field-old">reopened</span> → <span class="trac-field-new">closed</span> </li> <li><strong>resolution</strong> → <span class="trac-field-new">fixed</span> </li> </ul> <p> (In <a class="changeset" href="https://svn.boost.org/trac10/changeset/84052" title="Apply updated patches from #8476. Fixes #8476.">[84052]</a>) Apply updated patches from <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/8476" title="#8476: Patches: Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic. (closed: fixed)">#8476</a>. Fixes <a class="closed ticket" href="https://svn.boost.org/trac10/ticket/8476" title="#8476: Patches: Make Boost.regex compatible with Clang's -Wimplicit-fallthrough diagnostic. (closed: fixed)">#8476</a>. </p> Ticket