Boost C++ Libraries: Ticket #8483: Fix for reference type deduction in join_iterator.hpp

attachment set

stheophil@… — Mon, 22 Apr 2013 14:55:24 GMT

attachment → join_iterator_original.hpp.patch

Nathan Ridge — Thu, 30 May 2013 22:15:38 GMT

Could you please give an example of a piece of code that doesn't work as expected without this fix?

Thanks!

stheophil@… — Mon, 19 Aug 2013 15:07:24 GMT

I'm sorry it took so long for me to respond. The problem is easy to replicate:

typedef boost::join_iterator<
   std::vector<int>::const_iterator,
   std::vector<int>::iterator
> JoinIterator;
static_assert( std::is_same<
   typename JoinIterator::reference,
   int const&
>::value, "" );

The static_assert should not trigger but it does with the old implementation of join_iterator (using Visual Studio 2012). add_const< int& >::type is still int&. We need to remove the reference first, then add const then re-add the reference. (Or find an altogether better solution :-)

Nathan Ridge — Tue, 20 Aug 2013 06:06:13 GMT

(In [85400]) [range] Fixed a bug in join_iterator where joining a const range and a non-const range led to a compiler error (refs #8483).

Nathan Ridge — Tue, 20 Aug 2013 06:08:26 GMT

Thanks! Fixed in trunk.

owner changed

Neil Groves — Fri, 21 Feb 2014 20:39:27 GMT

owner changed from Neil Groves to Nathan Ridge

Hi Nathan! I see you have fixed this in the trunk. When you are happy would you please merge this to release and then close this ticket?

status changed; resolution set

Nathan Ridge — Sat, 22 Feb 2014 06:30:04 GMT

status new → closed
resolution → fixed

I have already merged it to the 'master' branch in git: https://github.com/boostorg/range/commit/4c2898345972bd6c44c6b55abb386af931cc8fb5. I guess I need to close the bug manually now that we use git (with svn I would put "fixes #8483" in the commit message of the merge and it would auto-close the bug).