Boost C++ Libraries: Ticket #8546: GCC 4.8 warns unused local typedef

attachment set

Sat, 04 May 2013 05:00:18 GMT

attachment → diff1

patch boost/concept/detail/general.hpp, boost/lexical_cast.hpp and boost/algorithm/string/detail/finder.hpp to eliminate unused local typedefs warning

viboes — Sat, 04 May 2013 09:29:11 GMT

Hi I'm suffering from the same warnings using other libraries.

Shouldn't this be included on boost/config/suffix.hpp

#if defined(__GNUC__) && ((__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 7)))
#  define BOOST_ATTRIBUTE_UNUSED __attribute__((unused))
#else
#  define BOOST_ATTRIBUTE_UNUSED
#endif

See #8549.

viboes — Sun, 07 Jul 2013 16:55:38 GMT

[84470] is related to this. Could this be closed?

owner, type, version, component changed

Thu, 18 Jul 2013 20:31:22 GMT

owner changed from jsiek to Marshall Clow
type Patches → Bugs
version Boost Development Trunk → Boost 1.54.0
component concept_check → algorithm

It appears 'boost/concept/detail/general.hpp' and 'boost/lexical_cast.hpp' have already been patched in the trunk.

I've recreated the patch to target the 'boost/algorithm/string/detail/finder.hpp' warnings:

finder.hpp:145
typedef ‘input_iterator_type’ locally defined but not used [-Wunused-local-typedefs]

finder.hpp:266
typedef ‘input_iterator_type’ locally defined but not used [-Wunused-local-typedefs]

finder.hpp:301
typedef ‘input_iterator_type’ locally defined but not used [-Wunused-local-typedefs]

finder.hpp:365
typedef ‘input_iterator_type’ locally defined but not used [-Wunused-local-typedefs]

finder.hpp:439
typedef ‘input_iterator_type’ locally defined but not used [-Wunused-local-typedefs]

attachment set

Thu, 18 Jul 2013 20:31:51 GMT

attachment → algorithm.patch

Marshall Clow — Mon, 22 Jul 2013 15:46:44 GMT

(In [85106]) Removed unused typedef; Refs #8546

status changed; resolution set

Marshall Clow — Tue, 23 Jul 2013 16:48:28 GMT

status new → closed
resolution → fixed

(In [85134]) Merge bug fix to Release; Fixes #8546

roland@… — Mon, 02 Dec 2013 10:22:57 GMT

It appears [84470] was not merged to any release (yet) -- it is not present in 1.55.0 and with that release, I get errors like the following with gcc 4.8 and -Wall -Werror:

include/boost/concept_check.hpp: In function ‘void boost::function_requires(Model*)’:
include/boost/concept_check.hpp:45:113: error: typedef ‘boost_concept_check45’ locally defined but not used [-Werror=unused-local-typedefs]
       BOOST_CONCEPT_ASSERT((Model));

so I think this bug may have been closed slightly prematurely.

John Maddock — Tue, 10 Dec 2013 19:09:32 GMT

This has just recently been merged to release in Git.

status, version, component changed; resolution deleted

anonymous — Mon, 03 Mar 2014 22:42:56 GMT

status closed → reopened
resolution fixed
version Boost 1.54.0 → Boost Development Trunk
component algorithm → GIL

This applies to the new GIL currently in trunk.

gereon.kremer@… — Tue, 01 Sep 2015 12:52:17 GMT

This behaviour still persists as of now (boost 1.58.0, clang 3.6.2). Have the above patches not made it, or is there another issue?

Marshall Clow — Tue, 01 Sep 2015 13:50:28 GMT

This behaviour still persists as of now (boost 1.58.0, clang 3.6.2).

I will admit to having trouble following this bug's history. It started out in Boost.Algorithm, moved into Boost.Concept, (and now GIL?) and I don't really know what you are referring to when you say "this behavior still persists".

The patch for Boost.Algorithm appeared in a release a long time ago, and the patch for Boost.Concept appears to be part of the 1.59 release.

If you're having other problems, let me know - but please be specific.

gereon.kremer@… — Wed, 02 Sep 2015 11:52:48 GMT

Okay, then I'll wait for 1.59 and see if it vanishes. As of 1.58 (with clang 3.6.2 and -Wall) and the following input, I still get this "unused typedef" warning:

#include <boost/concept_check.hpp>
template<typename T, typename TT>
void require_type(const TT& tt) {
    T t = tt;
    (void)(t);
}
template<typename T1>
struct UnaryMinus {
    T1 t;
    BOOST_CONCEPT_USAGE(UnaryMinus) { require_type<T1>(-t); }
};
int main() {
    BOOST_CONCEPT_ASSERT((UnaryMinus<int>));
}

Marshall Clow — Wed, 02 Sep 2015 15:00:36 GMT

Okay, then I'll wait for 1.59 and see if it vanishes

Boost 1.59.0 was released three weeks ago. :-)

Using that, I get no warning with your code and clang ToT or GCC 5.1

cc set

Mateusz Loskot — Thu, 16 Feb 2017 10:51:51 GMT

cc mateusz@… added

status changed; resolution set

Marshall Clow — Mon, 08 May 2017 17:12:01 GMT

status reopened → closed
resolution → fixed

I get no warnings (with Boost 1.64.0), so I'm closing this as fixed.